New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove compiler dependency: added new mapping test data format #716
Conversation
black format
Codecov Report
@@ Coverage Diff @@
## master #716 +/- ##
==========================================
+ Coverage 87.71% 88.65% +0.94%
==========================================
Files 76 125 +49
Lines 2173 2266 +93
Branches 264 263 -1
==========================================
+ Hits 1906 2009 +103
+ Misses 208 201 -7
+ Partials 59 56 -3
Continue to review full report at Codecov.
|
|
This format looks okay to me |
This comment has been minimized.
This comment has been minimized.
0f00750
to
7e81dd7
Compare
Update README.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Do you mean to still have
test/assets/test-curl-7.34.0.outandtest/assets/test-curl-7.34.0.out? - Where are the tests being run?
- Do are the common strings that we usually find when compiling with gcc being added to the fake binaries?
|
Looks like you're making great progress here! |
Co-authored-by: John Andersen <johnandersenpdx@gmail.com>
|
@pdxjohnny I am keeping two compiled binaries in assets because, testing our python strings module against fake binary won't be really useful. We have to make sure that our strings implementation give same result as strings command on real binaries. No, I am not going to add those common strings in every binary file we generate. I think it would be nice to have a separate test for that so that developer get more details. |
|
We don't have following test data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you make those issues you were talking about? Then this looks good, also, see my comment above ^
Here is the answer for these comments: #716 (comment). |
|
@Niraj-Kamdar, we have package test data for gimp, please see the commits in PR #726. |
I might have missed it. thanks! |
I have created separate python file to store mapping test data. I have done this because it would be nice to keep data separated from the code.
We can import whole array from the mapping_test_data file and use it directly in test_scanner.
@terriko, @pdxjohnny needs your opinions on this new structure.