-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added asynchronous strings and improved extractor #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #746 +/- ##
==========================================
- Coverage 86.97% 81.55% -5.42%
==========================================
Files 125 126 +1
Lines 2372 2445 +73
Branches 275 285 +10
==========================================
- Hits 2063 1994 -69
- Misses 245 381 +136
- Partials 64 70 +6
Continue to review full report at Codecov.
|
Niraj-Kamdar
force-pushed
the
master
branch
2 times, most recently
from
June 15, 2020 06:28
54b5fc0
to
daaa067
Compare
johnandersen777
approved these changes
Jun 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have created FileIO class for asynchronous file IO which just run synchronous IO in asyncio executor as mentioned by @pdxjohnny and splited util module into util and async_utils modules.