Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added asynchronous strings and improved extractor #746

Merged
merged 13 commits into from
Jun 18, 2020

Conversation

Niraj-Kamdar
Copy link
Contributor

@Niraj-Kamdar Niraj-Kamdar commented Jun 13, 2020

I have created FileIO class for asynchronous file IO which just run synchronous IO in asyncio executor as mentioned by @pdxjohnny and splited util module into util and async_utils modules.

@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2020

Codecov Report

Merging #746 into master will decrease coverage by 5.41%.
The diff coverage is 83.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #746      +/-   ##
==========================================
- Coverage   86.97%   81.55%   -5.42%     
==========================================
  Files         125      126       +1     
  Lines        2372     2445      +73     
  Branches      275      285      +10     
==========================================
- Hits         2063     1994      -69     
- Misses        245      381     +136     
- Partials       64       70       +6     
Flag Coverage Δ
#longtests 81.55% <83.92%> (-5.42%) ⬇️
Impacted Files Coverage Δ
cve_bin_tool/util.py 84.00% <ø> (-5.54%) ⬇️
cve_bin_tool/strings.py 73.33% <42.85%> (-26.67%) ⬇️
cve_bin_tool/extractor.py 58.69% <57.14%> (+2.07%) ⬆️
test/utils.py 86.84% <66.66%> (-9.83%) ⬇️
cve_bin_tool/async_utils.py 88.54% <88.54%> (ø)
test/test_extractor.py 97.80% <95.65%> (+23.29%) ⬆️
test/test_strings.py 100.00% <100.00%> (ø)
test/test_json.py 61.76% <0.00%> (-29.42%) ⬇️
cve_bin_tool/cvedb.py 53.14% <0.00%> (-29.25%) ⬇️
cve_bin_tool/checkers/xml2.py 61.36% <0.00%> (-27.28%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b44105a...cc2dc1c. Read the comment docs.

pytest marker don't work with unittest
update test
@johnandersen777 johnandersen777 merged commit 026d964 into intel:master Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants