Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asynchronous File module added #751

Merged
merged 4 commits into from
Jun 26, 2020
Merged

Asynchronous File module added #751

merged 4 commits into from
Jun 26, 2020

Conversation

Niraj-Kamdar
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jun 19, 2020

Codecov Report

Merging #751 into master will decrease coverage by 0.07%.
The diff coverage is 81.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #751      +/-   ##
==========================================
- Coverage   81.55%   81.47%   -0.08%     
==========================================
  Files         126      126              
  Lines        2445     2462      +17     
  Branches      285      287       +2     
==========================================
+ Hits         1994     2006      +12     
- Misses        381      387       +6     
+ Partials       70       69       -1     
Flag Coverage Δ
#longtests 81.47% <81.81%> (-0.08%) ⬇️
Impacted Files Coverage Δ
cve_bin_tool/file.py 72.41% <52.94%> (-27.59%) ⬇️
test/test_file.py 100.00% <100.00%> (ø)
cve_bin_tool/async_utils.py 91.66% <0.00%> (+3.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 026d964...a3de82d. Read the comment docs.

@Niraj-Kamdar
Copy link
Contributor Author

Niraj-Kamdar commented Jun 19, 2020

If you have noticed coverage is decreasing in every async PR by a few percent which is because of the additional synchronous function and platform specific instructions which isn't getting tested. It will increase once again when our async pipeline will be ready and I will remove this synchronous functions.

@pdxjohnny pdxjohnny merged commit 492107b into intel:master Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants