OutputEngine: Modernize error handling #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #828 +/- ##
==========================================
+ Coverage 83.21% 83.25% +0.03%
==========================================
Files 152 152
Lines 2550 2550
Branches 279 280 +1
==========================================
+ Hits 2122 2123 +1
+ Misses 359 358 -1
Partials 69 69
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
SinghHrmn
reviewed
Jul 18, 2020
Comment on lines
+115
to
+116
| f"An exception occurred while writing to the file {self.filename} " | ||
| "Switching Back to Default Naming Convention" |
There was a problem hiding this comment.
This should be a single string.
There was a problem hiding this comment.
It is.
evaluate this expression: print("hello " "world") you will know.
terriko
approved these changes
Jul 23, 2020
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.