OutputEngine: Fix generate_filename args signature #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Niraj-Kamdar
changed the title
Codecov Report
@@ Coverage Diff @@
## master #829 +/- ##
=======================================
Coverage 83.16% 83.16%
=======================================
Files 150 150
Lines 2542 2542
Branches 279 279
=======================================
Hits 2114 2114
Misses 359 359
Partials 69 69
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
SinghHrmn
reviewed
Jul 18, 2020
| @@ -89,7 +89,7 @@ def output_file(self, output_type="console"): | |||
|
|
|||
| # Check if we need to generate a filename | |||
| if not self.filename: | |||
| self.filename = generate_filename(self.filename, output_type) | |||
| self.filename = generate_filename(output_type) | |||
There was a problem hiding this comment.
Thanks for catching that. But I fixed that but I don't know how it showed up here maybe I forgot to save the file or something.
terriko
approved these changes
Jul 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.