Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Config file support #846

Merged
merged 8 commits into from
Aug 5, 2020
Merged

Added Config file support #846

merged 8 commits into from
Aug 5, 2020

Conversation

Niraj-Kamdar
Copy link
Contributor

@Niraj-Kamdar Niraj-Kamdar commented Jul 24, 2020

  • ConfigParser class created.
  • Added support for TOML (for sysadmins) and YAML (for devops users).
  • Add tests for ConfigParser
  • Add end-to-end tests for mixed use-case of command line + config file.
    closes: Discussion: Configuration file format #832

@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2020

Codecov Report

Merging #846 into master will decrease coverage by 0.69%.
The diff coverage is 67.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #846      +/-   ##
==========================================
- Coverage   88.60%   87.90%   -0.70%     
==========================================
  Files         160      162       +2     
  Lines        2606     2679      +73     
  Branches      281      289       +8     
==========================================
+ Hits         2309     2355      +46     
- Misses        232      254      +22     
- Partials       65       70       +5     
Flag Coverage Δ
#longtests 87.90% <67.59%> (-0.70%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/test_config.py 0.00% <0.00%> (ø)
cve_bin_tool/config.py 80.00% <80.00%> (ø)
test/test_cli.py 98.49% <80.00%> (-1.51%) ⬇️
cve_bin_tool/cli.py 86.82% <82.60%> (+2.33%) ⬆️
cve_bin_tool/error_handler.py 86.00% <100.00%> (+0.28%) ⬆️
cve_bin_tool/version_scanner.py 86.08% <100.00%> (ø)
cve_bin_tool/cve_scanner.py 80.50% <0.00%> (-0.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a153874...a57789f. Read the comment docs.

@Niraj-Kamdar Niraj-Kamdar force-pushed the config branch 3 times, most recently from bd7411e to 7faa3c3 Compare July 29, 2020 11:38
@terriko terriko merged commit a9a18a0 into intel:master Aug 5, 2020
@Niraj-Kamdar Niraj-Kamdar deleted the config branch August 6, 2020 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discussion: Configuration file format
3 participants