Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Add how to guides #864

Merged
merged 2 commits into from
Aug 19, 2020
Merged

Documentation: Add how to guides #864

merged 2 commits into from
Aug 19, 2020

Conversation

Niraj-Kamdar
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2020

Codecov Report

Merging #864 into master will decrease coverage by 2.29%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #864      +/-   ##
==========================================
- Coverage   87.31%   85.02%   -2.30%     
==========================================
  Files         164      164              
  Lines        2705     2705              
  Branches      295      295              
==========================================
- Hits         2362     2300      -62     
- Misses        272      326      +54     
- Partials       71       79       +8     
Flag Coverage Δ
#longtests 85.02% <ø> (-2.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cve_bin_tool/checkers/xml2.py 61.36% <0.00%> (-27.28%) ⬇️
test/test_json.py 68.96% <0.00%> (-20.69%) ⬇️
test/test_cli.py 80.45% <0.00%> (-18.05%) ⬇️
test/test_scanner.py 79.77% <0.00%> (-11.24%) ⬇️
cve_bin_tool/cli.py 83.33% <0.00%> (-3.04%) ⬇️
cve_bin_tool/version_scanner.py 84.34% <0.00%> (-1.74%) ⬇️
cve_bin_tool/extractor.py 59.05% <0.00%> (-1.58%) ⬇️
cve_bin_tool/cvedb.py 84.25% <0.00%> (-0.79%) ⬇️
test/test_checkers.py 100.00% <0.00%> (ø)
test/test_data/glibc.py 100.00% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf7e827...de5f0db. Read the comment docs.

how-to-docker


update
@terriko
Copy link
Contributor

terriko commented Aug 13, 2020

I wonder if (like in #862 ) we should use a symbolic link for the outputengine file rather than renaming. This one is less clear to me -- we don't have other documents pointing at it in its current location, and it is more of a user thing to do (as opposed to adding a checker which we expect to mostly be a developer thing to do).

@terriko
Copy link
Contributor

terriko commented Aug 13, 2020

And the docker scan stuff is looking good. I'm guessing from the dangling header at the end that you're not done with that doc yet.

@Niraj-Kamdar
Copy link
Contributor Author

Yes, for docker scan, I have written one way which is install and run cve-bin-tool inside container and just export final report to host. Other way is export directory to scan on host and run cve-bin-tool like we run on normal directory.

I forget to draft PR.

@Niraj-Kamdar
Copy link
Contributor Author

I have moved html template guide to how_to_guide directory because it will make our life easier when we host our site on Read-the-docs. And I think collecting every how to guide in one directory will be easy for user. We can just point user to this directory and he can find one which he is looking. But if we want to keep that on output_engine directory then I will change that.
I don't know about symbolic link but will look into it.

@Niraj-Kamdar Niraj-Kamdar marked this pull request as draft August 13, 2020 19:10
@Niraj-Kamdar Niraj-Kamdar marked this pull request as ready for review August 17, 2020 10:28
Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I might do a few North American English nitpicks in a separate commit later, but since that's more window dressing than substance let's get this merged first.

@terriko terriko merged commit 6098a68 into intel:master Aug 19, 2020
@Niraj-Kamdar Niraj-Kamdar deleted the howto branch August 19, 2020 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants