Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added example yml to run CVE Binary Tool in github actions #894

Merged
merged 5 commits into from Sep 2, 2020

Conversation

Niraj-Kamdar
Copy link
Contributor

@Niraj-Kamdar Niraj-Kamdar commented Aug 22, 2020

I have tested it on my github repo: https://github.com/Niraj-Kamdar/qpt_generator/actions/runs/219903197
I also want to submit this action for github action hackathon by dev.to. Is it okay?
Fixes: #272

@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2020

Codecov Report

Merging #894 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #894   +/-   ##
=======================================
  Coverage   84.70%   84.70%           
=======================================
  Files         167      167           
  Lines        2765     2765           
  Branches      298      298           
=======================================
  Hits         2342     2342           
  Misses        345      345           
  Partials       78       78           
Flag Coverage Δ
#longtests 84.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8e1866...00c1322. Read the comment docs.

@Niraj-Kamdar Niraj-Kamdar changed the title Add yml file for action Added example yml to run CVE Binary Tool in github actions Aug 22, 2020
@pdxjohnny
Copy link
Member

pdxjohnny commented Aug 24, 2020

If we're going to do this, we might as well go the rest of the way and provide them with a GitHub action that scans a specified directory: https://docs.github.com/en/actions/creating-actions/creating-a-docker-container-action. Do you think you have time to do that? If so that would be ideal.

@pdxjohnny pdxjohnny added the awaiting response Need more information from submitter label Aug 24, 2020
@Niraj-Kamdar

This comment has been minimized.

@Niraj-Kamdar
Copy link
Contributor Author

I see GitHub has added another way to create actions: "composite" action. Now we can use another action to create actions which is perfect for our use case.
When I learned creating actions they only had two options docker and typescript.

@Niraj-Kamdar
Copy link
Contributor Author

Today I have explored github's composite action feature but it is still actively being developed and lacks many features that I need to create a working action for cve-bin-tool. We need to wait until github introduces those features.

@pdxjohnny pdxjohnny merged commit 0a78d8b into intel:master Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting response Need more information from submitter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write instructions/config to run CVE Binary Tool in github actions
3 participants