Add support for reference lookups within methods #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JonatanWaern
commented
Jul 2, 2025
JonatanWaern
commented
- Add declaration spans to methods
- Make fields of structure statements public
- Fix declarations in for loops headers
- Do not discard if-statements without elses
- Allow objects_to_symbols to report errors
- Use try-lock to detect lookup loops
- Macro for internal errors
- Special handling of lookups on method contexts
Contributor
Author
|
@TSonono Would be very useful if you could check out and build this locally to test it on your devices a bit. I will be doing some edge-case testing myself (I think, already, I can see declarations leaking through scopes in some cases) |
Contributor
Author
|
Scope-escaping should be less now, though turning off reference caching for lookups within methods is certainly not ideal. |
JonatanWaern
force-pushed
the
references-within-methods
branch
from
b158e03 to
f73d3af
Compare
Sure |
JonatanWaern
force-pushed
the
references-within-methods
branch
from
f73d3af to
ee459ae
Compare
JonatanWaern
force-pushed
the
references-within-methods
branch
from
ee459ae to
94955cd
Compare
Signed-off-by: Jonatan Waern <jonatan.waern@intel.com>
Were missing 'saved', 'session', and the ability to multi-declare Signed-off-by: Jonatan Waern <jonatan.waern@intel.com>
Luckily, we do not use structural statement information for anything yet. So this did not cause any errors. Signed-off-by: Jonatan Waern <jonatan.waern@intel.com>
Also get rid of the double-errors list Signed-off-by: Jonatan Waern <jonatan.waern@gmail.com>
Avoids mistakes in writing "internal error" prefix Signed-off-by: Jonatan Waern <jonatan.waern@intel.com>
Signed-off-by: Jonatan Waern <jonatan.waern@intel.com>
JonatanWaern
force-pushed
the
references-within-methods
branch
from
94955cd to
532be13
Compare
Signed-off-by: Jonatan Waern <jonatan.waern@intel.com>
Signed-off-by: Jonatan Waern
JonatanWaern
force-pushed
the
references-within-methods
branch
from
532be13 to
c7a299b
Compare
Signed-off-by: Jonatan Waern <jonatan.waern@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.