Broadwell-DE FSP

[zaolin]

@nate-desimone-intel Currently headers and sample code are missing in the repository. Can you add the missing ones?

[zaolin]

Also maybe update them?

[nate-desimone]

Hi @zaolin, I see the following: https://github.com/IntelFsp/FSP/blob/master/BroadwellDEFspBinPkg/include/fspvpd.h

Is there something more you are looking for?

[zaolin]

As you can see there are more missing headers and source code @nate-desimone-intel https://review.coreboot.org/cgit/coreboot.git/tree/src/vendorcode/intel/fsp1_0/broadwell_de/include
https://review.coreboot.org/cgit/coreboot.git/tree/src/vendorcode/intel/fsp1_0/broadwell_de/srx

[nate-desimone]

Hi @zaolin, when comparing the contents of both repos, they are identical:
https://github.com/IntelFsp/FSP/tree/master/BroadwellDEFspBinPkg/include
https://review.coreboot.org/cgit/coreboot.git/tree/src/vendorcode/intel/fsp1_0/broadwell_de/include

The copy of fspvpd.h in github is newer than the version in the coreboot repo:

The fspsupport.c file is also present in github, just under a different directory structure. I am closing this issue.

[zaolin]

@nate-desimone-intel Thanks, got it. Just was a little bit confused.