From 29fc73a1031df47d496a41b5cc7b601b4be5d4e6 Mon Sep 17 00:00:00 2001 From: Yonatan Goldschmidt Date: Sun, 3 Apr 2022 03:59:18 +0300 Subject: [PATCH 1/3] Elaborate error message on /dev/kmsg failure --- gprofiler/kernel_messages.py | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/gprofiler/kernel_messages.py b/gprofiler/kernel_messages.py index 7ac17dae1..68ac941bc 100644 --- a/gprofiler/kernel_messages.py +++ b/gprofiler/kernel_messages.py @@ -23,15 +23,19 @@ def on_missed(self) -> None: def get_kernel_messages_provider() -> KernelMessagesProvider: if DefaultKernelMessagesProvider is EmptyKernelMessagesProvider: - logger.info("Profilee error monitoring is not supported for this system.") + logger.info( + "Profilee error monitoring via kernel messages is not supported for this system" + " (this does not prevent profiling)" + ) return DefaultKernelMessagesProvider() try: return GProfilerKernelMessagesProvider() except Exception: logger.warning( - "Failed to start kernel messages listener. Profilee error monitoring not available. (Do you have permission" - " to read /dev/kmsg?)", + "Failed to start kernel messages listener. Profilee error monitoring via kernel messages" + " is not available (this does not prevent profiling). Do you have permission" + " to read /dev/kmsg?", exc_info=True, ) return EmptyKernelMessagesProvider() From 18d9d9eb65de854d70e810b364d58f7677f0e3dd Mon Sep 17 00:00:00 2001 From: Yonatan Goldschmidt Date: Sun, 3 Apr 2022 04:03:02 +0300 Subject: [PATCH 2/3] Elaborate proc_events start error message --- gprofiler/profilers/java.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gprofiler/profilers/java.py b/gprofiler/profilers/java.py index 9b76a564d..673dd60f0 100644 --- a/gprofiler/profilers/java.py +++ b/gprofiler/profilers/java.py @@ -847,7 +847,8 @@ def start(self) -> None: try: proc_events.register_exit_callback(self._proc_exit_callback) except Exception: - logger.warning("Failed to enable proc_events listener for exited Java processes", exc_info=True) + logger.warning("Failed to enable proc_events listener for exited Java processes" + " (this does not prevent Java profiling)", exc_info=True) else: self._enabled_proc_events = True From 0e130a372cfb4e24a8d3770557bdaff13d231d45 Mon Sep 17 00:00:00 2001 From: Yonatan Goldschmidt Date: Sun, 17 Apr 2022 15:53:17 +0300 Subject: [PATCH 3/3] fix format --- gprofiler/profilers/java.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/gprofiler/profilers/java.py b/gprofiler/profilers/java.py index 673dd60f0..c89813def 100644 --- a/gprofiler/profilers/java.py +++ b/gprofiler/profilers/java.py @@ -847,8 +847,11 @@ def start(self) -> None: try: proc_events.register_exit_callback(self._proc_exit_callback) except Exception: - logger.warning("Failed to enable proc_events listener for exited Java processes" - " (this does not prevent Java profiling)", exc_info=True) + logger.warning( + "Failed to enable proc_events listener for exited Java processes" + " (this does not prevent Java profiling)", + exc_info=True, + ) else: self._enabled_proc_events = True