Fix the auto cast of brgemm and the correctness issue of deepTileatmul #247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
zhczhong
commented
Aug 15, 2024
zhczhong
commented
- Fix CPU pipeline failed for some mlir #246. The definition of brgemm autocast is wrong and the root fix is in the upstraem([mlir][linalg] fix linalg.batch_reduce_matmul auto cast llvm/llvm-project#102585)
- Matmul correctness check failed #235: The batch_matmul hasn't been supported now and skip it.
zhczhong
requested review from
WangJialei-A,
ZhennanQin,
ciyongch and
xurui1995
ZhennanQin
approved these changes
Aug 15, 2024
xurui1995
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.