Readme for device plugins helm charts #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mythi
reviewed
Sep 21, 2022
Contributor
There was a problem hiding this comment.
looks like this belongs to Get Helm Repository Info.
poussa
requested changes
Sep 22, 2022
charts/qat-device-plugin/README.md
Outdated
Contributor
There was a problem hiding this comment.
put the helm search repo intel into single quotes so it looks like a command. Same for all the charts.
Contributor
There was a problem hiding this comment.
You should say that the CRDs are installed as part of the chart.
Contributor
There was a problem hiding this comment.
Add a section which document the variables, like in the other charts.
poussa
reviewed
Sep 26, 2022
| ## Prerequisites | ||
| - cert-manager | ||
| - NFD charts [optional] | ||
|
|
Contributor
There was a problem hiding this comment.
Add links to the cert manager and NFD helm charts, please.
mythi
approved these changes
Sep 27, 2022
poussa
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What parameters should I define for operator helm chart? In the values.yaml of operator there is only a reference to its image.