This repository was archived by the owner on Aug 5, 2022. It is now read-only.
meta-refkit-extra: move Boost package config to configuration file. #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pohly
reviewed
Apr 28, 2017
| SUPPORTED_RECIPES[refkit-extra-supported-recipes.txt] = "extra" | ||
|
|
||
| # Caffe needs Boost Python 3 bindings. Enable them in Boost. | ||
| PACKAGECONFIG_pn-boost += "python" |
Contributor
There was a problem hiding this comment.
I think you may need PACKAGECONFIG_append_pn-boost = " python" here.
PACKAGECONFIG_pn-boost overrides the weaker PACKAGECONFIG default instead of extending it.
Contributor
Author
There was a problem hiding this comment.
Ok. I checked that python was part of the PACKAGECONFIG, but I didn't check if something was missing there. I'll fix the patch.
Do not have Boost PACKAGE_CONFIG variable set in a .bbappend file, because adding or removing layers should not affect the build result. Have the configuration setting instead in layer's distro config file. Signed-off-by: Ismo Puustinen <ismo.puustinen@intel.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not have Boost PACKAGE_CONFIG variable set in a .bbappend file, because adding or removing layers should not affect the build result. Have the configuration setting instead in layer's distro config file.