This repository was archived by the owner on Aug 5, 2022. It is now read-only.
images: drop .dsk, clean-ups, and CI optimizations #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pohly
reviewed
Jun 14, 2017
Contributor
pohly
left a comment
pohly
left a comment
There was a problem hiding this comment.
The argument for dropping .wic.xz.sha256 is a bit misleading. The intention probably was to have separate checksums that get communicated to downloaders via some separate channel (release announcement, for example) so that the authenticity of the downloaded file can be verified after downloading it.
xz guarantees that the file is not corrupted, but not that it is authentic.
I'm fine with dropping .wic.xz.sha256 nevertheless, because we never used it.
pohly
approved these changes
Jun 14, 2017
Contributor
Author
|
I don't think the argument is totally misleading: the conversion is redundant and for CI-purposes file download integrity check is sufficient. I agree the wording could be improved though. Anyway, thanks for the review. This obsoletes #173 |
mythi
added a commit
to mythi/intel-iot-refkit
that referenced
this pull request
Jun 15, 2017
Some image conversions are redundant and can be skipped in favor of optimizing CI build-times. It's enough to compress in xz format only. For download integrity checking, we use xz's built-in mechanism and change it to use sha256. Signed-off-by: Mikko Ylinen <mikko.ylinen@linux.intel.com>
zip image conversion is already part of OE-core and the vdi format isn't used so it's safe to drop image_types_extra completely. Signed-off-by: Mikko Ylinen <mikko.ylinen@linux.intel.com>
wic image format has been the default for some time now and
it's time to remove the unused custom dsk image format.
image-dsk.bbclass is kept since do_uefiapp is still used but
modified to:
* work with empty DSK_IMAGE_LAYOUT (set as default)
* not provide IMAGE_CMD_dsk anymore
Signed-off-by: Mikko Ylinen <mikko.ylinen@linux.intel.com>
Post-build testing builds images but only .wic is sufficient (default in IMAGE_FSTYPES). We skip compression and bmap formats for oe-selftests to optimize testing time. [YOCTO: #11506] Signed-off-by: Mikko Ylinen <mikko.ylinen@linux.intel.com>
mythi
added a commit
to mythi/intel-iot-refkit
that referenced
this pull request
Jun 15, 2017
mythi
added a commit
to mythi/intel-iot-refkit
that referenced
this pull request
Jun 16, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.