This repository was archived by the owner on Aug 5, 2022. It is now read-only.
CI Jenkinsfile: attempt publish even after build failure #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okartau
force-pushed
the
publish-logs-on-build-failure
branch
5 times, most recently
from
c2f6841 to
dd5a099
Compare
mythi
reviewed
Feb 27, 2017
docker/publish-project.sh
Outdated
| rsync -qzrl --prune-empty-dirs --include "log.*" --include "*/" --exclude "*" ${_BRESULT}/work*/* ${_RSYNC_DEST}/detailed-logs/${TARGET_MACHINE}/ | ||
| if [ -d ${_BRESULT}/work ]; then | ||
| create_remote_dirs ${_RSYNC_DEST} detailed-logs/${TARGET_MACHINE}/ | ||
| rsync -qzrl --prune-empty-dirs --include "log.*" --include "*/" --exclude "*" ${_BRESULT}/work*/* ${_RSYNC_DEST}/detailed-logs/${TARGET_MACHINE}/ |
Contributor
There was a problem hiding this comment.
I wonder should it be --include "log.do_*". log.* copies some python logs that are not task logs.
okartau
force-pushed
the
publish-logs-on-build-failure
branch
from
dd5a099 to
62724cf
Compare
Contributor
|
test this please |
Sometimes detailed build logs contain important information which gets lost after failed build phase because we stop the pipeline. Let's run publish part always, trying to copy out whatever we can. Publish script needs another check for workdir existence to handle all states without trouble. Make detailed logs publish mask more exact to exclude irrelevant logs.
okartau
force-pushed
the
publish-logs-on-build-failure
branch
from
62724cf to
134b0c7
Compare
Contributor
Author
|
should we mark such incomplete file set, for example by adding a flag file with explanation as its name THIS_SET_INCOMPLETE_some_more_explanation, |
Contributor
|
This is good as it is now. |
nagineni
pushed a commit
to nagineni/intel-iot-refkit
that referenced
this pull request
Jun 26, 2017
* meta-iot-web 1e515ff...775f6c2 (6): > Merge pull request intel#46 from nagineni/update_restserver > iot-rest-api-server.bb: Update iot-rest-api-server to v0.5.0 > Merge pull request intel#45 from nagineni/node_gcc_7 > nodejs: Fix Node.js build errors with gcc7 > Merge pull request intel#43 from TizenTeam/sandbox/pcoval/on/master/latest > nodejs: Fix FTBFS by adding missing argument to d.getVar Signed-off-by: Sudarsana Nagineni <sudarsana.nagineni@intel.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes detailed build logs contain important information
which gets lost after failed build phase because we stop the pipeline.
Let's run publish part always, trying to copy out whatever we can.