Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Seeking with VC1 after 6702b01ee3598017f05374bfc7956493f790361c #260

Merged
merged 3 commits into from Sep 4, 2017

Conversation

@fritsch
Copy link
Contributor

commented Aug 26, 2017

We found some issues with kodi when seeking through VC-1 files after above commit was merged. It seems the priv_data is not checked for being null.

You can reproduce the issue when pausing / resuming VC-1 files. The gen8_mfd change was tested working.

Debuglog with backtrace: http://sprunge.us/PPWX
Sample to reproduce: http://milhouse.libreelec.tv/other/MKV9_vc-1_6ch_ac3_dts_pcm.mkv

xhaihao referenced this pull request Aug 30, 2017
implement intensity compensation for VC-1 decoding
Intensity compensation was not present for B-frames, but only for P-frames. When a P-frame flags intensity compensation for its forward reference frame, all subsequent B-frames that use this reference frame as well, need to do intensity compensation as well.
@xhaihao

This comment has been minimized.

Copy link
Contributor

commented Sep 4, 2017

I think GEN6 should have the same issue, could you fix this issue in gen6_mfd.c?

@fritsch

This comment has been minimized.

Copy link
Contributor Author

commented Sep 4, 2017

Done.

@fritsch fritsch force-pushed the fritsch:vc1fixup branch from 462a6d3 to b08d913 Sep 4, 2017

@xhaihao
xhaihao approved these changes Sep 4, 2017
Copy link
Contributor

left a comment

LGTM

@xhaihao xhaihao merged commit a6039cb into intel:master Sep 4, 2017

6 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
intel/ci/fedora/25/pr Build intel-vaapi-driver-b08d913ef5a9 finished with status SUCCESSFUL
Details
intel/ci/fedora/26/pr Build intel-vaapi-driver-b08d913ef5a9 finished with status SUCCESSFUL
Details
intel/ci/ubuntu/trusty/pr Build intel-vaapi-driver-b08d913ef5a9 finished with status SUCCESSFUL
Details
intel/ci/ubuntu/xenial/pr Build intel-vaapi-driver-b08d913ef5a9 finished with status SUCCESSFUL
Details
intel/ci/ubuntu/zesty/pr Build intel-vaapi-driver-b08d913ef5a9 finished with status SUCCESSFUL
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.