adjust call sequence to ensure authenticate operation is executed #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XinfengZhang
force-pushed
the
hot_fix_x11
branch
from
e6809c4
to
60f6653
Compare
va/va.c
Outdated
| @@ -380,19 +392,14 @@ static VAStatus va_getDriverNameByIndex(VADisplay dpy, char **driver_name, int c | |||
| va_infoMessage(dpy, "User requested driver '%s'\n", *driver_name); | |||
| return VA_STATUS_SUCCESS; | |||
| } else if (driver_name_env && (geteuid() == getuid())) { | |||
| if(!(*driver_name)) | |||
There was a problem hiding this comment.
I'm almost sure this is wrong, unless something very clever is involved here: you seem to free *driver_name when it is 0...
There was a problem hiding this comment.
sorry about it, I made a mistake, thanks you
XinfengZhang
force-pushed
the
hot_fix_x11
branch
from
60f6653
to
a80d2fe
Compare
fixes intel#355 Signed-off-by: Carl Zhang <carl.zhang@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #355
Signed-off-by: Carl Zhang carl.zhang@intel.com