Skip to content
Permalink
Browse files
net/core: XDP metadata BTF netlink API
Add new devlink XDP attributes to be used to query or setup XDP metadata
BTF state.

IFLA_XDP_MD_BTF_ID: type NLA_U32.
IFLA_XDP_MD_BTF_STATE: type = NLA_U8.

On XDP query driver reports current loaded BTF ID, and its state if
active or not.

On XDP setup, driver will use these attributes to activate/deactivate
a specific BTF ID.

Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
Signed-off-by: Jithu Joseph <jithu.joseph@intel.com>
Signed-off-by: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>
Signed-off-by: Aravindhan Gunasekaran <aravindhan.gunasekaran@intel.com>
  • Loading branch information
zulkifl3 authored and zhoufuro committed Feb 8, 2022
1 parent 6a33255 commit bb9ef3cb40b9748d9a676d8d381668f0ca3a9a9f
Show file tree
Hide file tree
Showing 4 changed files with 86 additions and 2 deletions.
@@ -932,6 +932,10 @@ enum bpf_netdev_command {
*/
XDP_SETUP_PROG,
XDP_SETUP_PROG_HW,
/* Setup/query XDP Meta Data BTF */
XDP_SETUP_MD_BTF,
XDP_QUERY_MD_BTF,

/* BPF program for offload callbacks, invoked at program load time. */
BPF_OFFLOAD_MAP_ALLOC,
BPF_OFFLOAD_MAP_FREE,
@@ -955,6 +959,7 @@ struct bpf_xdp_entity {
struct bpf_prog *prog;
struct bpf_xdp_link *link;
};
struct btf;

struct netdev_bpf {
enum bpf_netdev_command command;
@@ -963,7 +968,11 @@ struct netdev_bpf {
struct {
u32 flags;
struct bpf_prog *prog;
struct netlink_ext_ack *extack;
};
/* XDP_{SETUP/QUERY}_MD_BTF */
struct {
u8 btf_enable;
u32 btf_id;
};
/* BPF_OFFLOAD_MAP_ALLOC, BPF_OFFLOAD_MAP_FREE */
struct {
@@ -974,6 +983,7 @@ struct netdev_bpf {
struct xsk_buff_pool *pool;
u16 queue_id;
} xsk;
struct netlink_ext_ack *extack;
};
};

@@ -4095,6 +4105,9 @@ int bpf_xdp_link_attach(const union bpf_attr *attr, struct bpf_prog *prog);
u8 dev_xdp_prog_count(struct net_device *dev);
u32 dev_xdp_prog_id(struct net_device *dev, enum bpf_xdp_mode mode);

int dev_xdp_setup_md_btf(struct net_device *dev, struct netlink_ext_ack *extack,
u8 enable);
u32 dev_xdp_query_md_btf(struct net_device *dev, u8 *enabled);
int __dev_forward_skb(struct net_device *dev, struct sk_buff *skb);
int dev_forward_skb(struct net_device *dev, struct sk_buff *skb);
int dev_forward_skb_nomtu(struct net_device *dev, struct sk_buff *skb);
@@ -1207,6 +1207,8 @@ enum {
IFLA_XDP_SKB_PROG_ID,
IFLA_XDP_HW_PROG_ID,
IFLA_XDP_EXPECTED_FD,
IFLA_XDP_MD_BTF_ID,
IFLA_XDP_MD_BTF_STATE,
__IFLA_XDP_MAX,
};

@@ -9785,6 +9785,59 @@ int dev_change_xdp_fd(struct net_device *dev, struct netlink_ext_ack *extack,
return err;
}

/**
* dev_xdp_query_md_btf - Query meta data btf of a device
* @dev: device
* @enabled: 1 if enabled, 0 otherwise
*
* Returns btf id > 0 if valid
*/
u32 dev_xdp_query_md_btf(struct net_device *dev, u8 *enabled)
{
struct netdev_bpf xdp;
bpf_op_t ndo_bpf;

ndo_bpf = dev->netdev_ops->ndo_bpf;
if (!ndo_bpf)
return 0;

memset(&xdp, 0, sizeof(xdp));
xdp.command = XDP_QUERY_MD_BTF;

if (ndo_bpf(dev, &xdp))
return 0; /* 0 is an invalid btf id */

*enabled = xdp.btf_enable;
return xdp.btf_id;
}

/**
* dev_xdp_setup_md_btf - enable or disable meta data btf for a device
* @dev: device
* @extack: netlink extended ack
* @enable: 1 to enable, 0 to disable
*
* Returns 0 on success
*/
int dev_xdp_setup_md_btf(struct net_device *dev, struct netlink_ext_ack *extack,
u8 enable)
{
struct netdev_bpf xdp;
bpf_op_t ndo_bpf;

ndo_bpf = dev->netdev_ops->ndo_bpf;
if (!ndo_bpf)
return -EOPNOTSUPP;

memset(&xdp, 0, sizeof(xdp));

xdp.command = XDP_SETUP_MD_BTF;
xdp.btf_enable = enable;
xdp.extack = extack;

return ndo_bpf(dev, &xdp);
}

/**
* dev_new_index - allocate an ifindex
* @net: the applicable net namespace
@@ -1453,8 +1453,9 @@ static int rtnl_xdp_report_one(struct sk_buff *skb, struct net_device *dev,

static int rtnl_xdp_fill(struct sk_buff *skb, struct net_device *dev)
{
u32 prog_id, md_btf_id;
u8 md_btf_enabled = 0;
struct nlattr *xdp;
u32 prog_id;
int err;
u8 mode;

@@ -1487,6 +1488,10 @@ static int rtnl_xdp_fill(struct sk_buff *skb, struct net_device *dev)
goto err_cancel;
}

md_btf_id = dev_xdp_query_md_btf(dev, &md_btf_enabled);
nla_put_u32(skb, IFLA_XDP_MD_BTF_ID, md_btf_id);
nla_put_u8(skb, IFLA_XDP_MD_BTF_STATE, md_btf_enabled);

nla_nest_end(skb, xdp);
return 0;

@@ -1931,6 +1936,8 @@ static const struct nla_policy ifla_xdp_policy[IFLA_XDP_MAX + 1] = {
[IFLA_XDP_ATTACHED] = { .type = NLA_U8 },
[IFLA_XDP_FLAGS] = { .type = NLA_U32 },
[IFLA_XDP_PROG_ID] = { .type = NLA_U32 },
[IFLA_XDP_MD_BTF_ID] = { .type = NLA_U32 },
[IFLA_XDP_MD_BTF_STATE] = { .type = NLA_U8 },
};

static const struct rtnl_link_ops *linkinfo_to_kind_ops(const struct nlattr *nla)
@@ -2936,6 +2943,15 @@ static int do_setlink(const struct sk_buff *skb,
goto errout;
status |= DO_SETLINK_NOTIFY;
}

if (xdp[IFLA_XDP_MD_BTF_STATE]) {
u8 enable = nla_get_u8(xdp[IFLA_XDP_MD_BTF_STATE]);

err = dev_xdp_setup_md_btf(dev, extack, enable);
if (err)
goto errout;
status |= DO_SETLINK_NOTIFY;
}
}

errout:

0 comments on commit bb9ef3c

Please sign in to comment.