[SYCL] Cleanup and optimize stream E2E tests #10137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Defining `SYCL_SIMPLE_SWIZZLES` significantly increases compilation time of the test (16s -> 1m 16s on my machine) and we don't really need to have all those swizzles in the test. We could use other methods, which return `__swizzled_vec__`, such as `odd` or `hi`, which is done in this commit.
Contributor
Author
|
Changes in the PR couldn't cause pre-commit issues in other tests. It seems to me that they are caused by a weird merge with |
AlexeySachkov
deleted the
private/asachkov/cleanup-and-optimize-stream-e2e-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed accidentally committed binary. Updated some comments.
Removed use of simple swizzles to significantly speed up compilation (1m 16s -> 16s on my machine).