From 22ed401eb31b0e2f86f6bf9ae682439a84aea85b Mon Sep 17 00:00:00 2001 From: Andrei Elovikov Date: Fri, 25 Aug 2023 11:37:00 -0700 Subject: [PATCH] [SYCL] Fix an assert in sycl/source/detail/graph_impl.cpp 1) String literal is always true, it should have been ``` assert(false && "Message"); ``` 2) Avoid unnecessary `if/else` --- sycl/source/detail/graph_impl.cpp | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/sycl/source/detail/graph_impl.cpp b/sycl/source/detail/graph_impl.cpp index aa51eb9d0c44c..5ec00ce779715 100644 --- a/sycl/source/detail/graph_impl.cpp +++ b/sycl/source/detail/graph_impl.cpp @@ -133,12 +133,10 @@ std::shared_ptr graph_impl::addSubgraphNodes( *NewNodesIt = NodeCopy; NodesMap.insert({Node, NodeCopy}); for (auto &NextNode : Node->MSuccessors) { - if (NodesMap.find(NextNode) != NodesMap.end()) { - auto Successor = NodesMap[NextNode]; - NodeCopy->registerSuccessor(Successor, NodeCopy); - } else { - assert("Node duplication failed. A duplicated node is missing."); - } + assert(NodesMap.find(NextNode) != NodesMap.end() && + "Node duplication failed. A duplicated node is missing."); + auto Successor = NodesMap[NextNode]; + NodeCopy->registerSuccessor(Successor, NodeCopy); } }