Skip to content

[SYCL][HIP] Replace for loop to copy results with std::memcpy. #11779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2023
Merged

[SYCL][HIP] Replace for loop to copy results with std::memcpy. #11779

merged 1 commit into from
Nov 6, 2023

Conversation

@mmoadeli
Copy link
Contributor

@mmoadeli mmoadeli commented Nov 3, 2023

Replace for loop to copy results with std::memcpy which showed slightly better performance.

@mmoadeli mmoadeli requested a review from a team as a code owner November 3, 2023 16:49
dkhaldi
dkhaldi approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@dkhaldi dkhaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@againull againull closed this Nov 3, 2023
@againull againull reopened this Nov 3, 2023
@mmoadeli mmoadeli requested a review from JackAKirk November 6, 2023 13:36
@againull againull closed this Nov 6, 2023
@againull againull reopened this Nov 6, 2023
@againull againull merged commit 28cf832 into intel:sycl Nov 6, 2023
@mmoadeli mmoadeli deleted the hip-joint_matrix-memcpy branch November 7, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkhaldi dkhaldi dkhaldi approved these changes

+1 more reviewer

@JackAKirk JackAKirk JackAKirk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mmoadeli @dkhaldi @JackAKirk @againull