From 726228b8db46e065a469bf8ab77c00bc334920f1 Mon Sep 17 00:00:00 2001 From: Artur Gainullin Date: Fri, 3 Nov 2023 15:57:55 -0700 Subject: [PATCH 1/2] [SYCL][E2E] dmem_varied.cpp test missing required sync point Test is missing required wait() between initializing ptrs and reading it. This was causing falky failures. --- sycl/test-e2e/USM/dmem_varied.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sycl/test-e2e/USM/dmem_varied.cpp b/sycl/test-e2e/USM/dmem_varied.cpp index 440ffcfe4c09b..0069ade282153 100644 --- a/sycl/test-e2e/USM/dmem_varied.cpp +++ b/sycl/test-e2e/USM/dmem_varied.cpp @@ -84,7 +84,7 @@ int main() { *ptrs[i] = 1; } }); - }); + }).wait(); size_t *res = (size_t *)aligned_alloc_shared(alignof(size_t), sizeof(size_t), q); From c9e5e753b5ace59d1d4a3c083e6f7e0c822cf293 Mon Sep 17 00:00:00 2001 From: Artur Gainullin Date: Fri, 3 Nov 2023 16:03:05 -0700 Subject: [PATCH 2/2] Fix formatting --- sycl/test-e2e/USM/dmem_varied.cpp | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/sycl/test-e2e/USM/dmem_varied.cpp b/sycl/test-e2e/USM/dmem_varied.cpp index 0069ade282153..ef8bc916e5185 100644 --- a/sycl/test-e2e/USM/dmem_varied.cpp +++ b/sycl/test-e2e/USM/dmem_varied.cpp @@ -79,12 +79,12 @@ int main() { } q.submit([&](handler &h) { - h.single_task([=]() { - for (size_t i = 0; i < count; ++i) { - *ptrs[i] = 1; - } - }); - }).wait(); + h.single_task([=]() { + for (size_t i = 0; i < count; ++i) { + *ptrs[i] = 1; + } + }); + }).wait(); size_t *res = (size_t *)aligned_alloc_shared(alignof(size_t), sizeof(size_t), q);