[SYCL][ESIMD] Add compile time checks for lsc_atomic_update accessor based API #11849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v-klochkov
reviewed
Nov 9, 2023
fineg74
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
# Conflicts: # sycl/include/sycl/ext/intel/experimental/esimd/memory.hpp
v-klochkov
reviewed
Dec 5, 2023
v-klochkov
reviewed
Dec 5, 2023
v-klochkov
reviewed
Dec 5, 2023
Contributor
v-klochkov
left a comment
v-klochkov
left a comment
There was a problem hiding this comment.
Looks good. I have only two minor comments.
v-klochkov
approved these changes
Dec 5, 2023
v-klochkov
approved these changes
Dec 5, 2023
Contributor
Author
|
SYCL E2E on AWS CUDA test failures are not related to the change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.