[SYCL][SCLA] Add sycl::aspect::ext_oneapi_private_alloca
#13181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victor-eds
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
victor-eds
commented
Mar 27, 2024
Comment on lines
+45
to
+46
| ; CHECK-RT: %[[LENGTH:.*]] = call i16 @_Z20__spirv_SpecConstantis(i32 2, i16 1) | ||
| ; CHECK-RT: {{.*}} = alloca %my_range, i16 %[[LENGTH]], align 64 |
There was a problem hiding this comment.
Previously missing
Comment on lines
-13
to
+18
| @size_i64 = internal addrspace(1) constant %"class.sycl::_V1::specialization_id" { i64 10 }, align 8 | ||
| @size_i32 = internal addrspace(1) constant %"class.sycl::_V1::specialization_id.0" { i32 120 }, align 4 | ||
| @size_i16 = internal addrspace(1) constant %"class.sycl::_V1::specialization_id.1" { i16 1 }, align 2 | ||
| @size_i64 = addrspace(1) constant %"class.sycl::_V1::specialization_id" { i64 10 }, align 8 | ||
| @size_i32 = addrspace(1) constant %"class.sycl::_V1::specialization_id.0" { i32 120 }, align 4 | ||
| @size_i16 = addrspace(1) constant %"class.sycl::_V1::specialization_id.1" { i16 1 }, align 2 |
There was a problem hiding this comment.
Needed to not drop
| #include <sycl/sycl.hpp> | ||
| #include <sycl/detail/core.hpp> |
There was a problem hiding this comment.
Also did this in all the tests
| @@ -1,6 +1,5 @@ | |||
| // RUN: %{build} -w -o %t.out | |||
| // RUN: echo 1 | %{run} %t.out | |||
| // UNSUPPORTED: cuda || hip | |||
There was a problem hiding this comment.
Not needed, using lit.local.cfg
| @@ -0,0 +1,31 @@ | |||
| // RUN: %clangxx %s -fsycl -fsycl-device-only -S -emit-llvm -o - | FileCheck %s | |||
There was a problem hiding this comment.
Run LLVM passes to check propagation of used aspects
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
victor-eds
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
|
Changes span different components as we need to:
|
victor-eds
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
victor-eds
force-pushed
the
alloca-aspect
branch
from
fb7cab1
to
2a9ba8a
Compare
victor-eds
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
victor-eds
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
victor-eds
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/dpcpp-tools-reviewers , @intel/llvm-reviewers-runtime, can I have a quick look here, please? |
againull
reviewed
Apr 2, 2024
Add aspect to check for `sycl_ext_oneapi_private_alloca` extension support. Only SPIR-V (OpenCL and Level Zero) devices have this aspect. In CodeGen, propagate this aspect when creating the `llvm.sycl.alloca.*` intrinsic. In `sycl-post-link`, do not assert on unsupported targets. Instead, assume the default value for the size specialization constant is used and handle the error at runtime. Signed-off-by: Victor Perez <victor.perez@codeplay.com>
victor-eds
force-pushed
the
alloca-aspect
branch
from
bd5d6bd
to
cb3022f
Compare
AlexeySachkov
approved these changes
Apr 3, 2024
victor-eds
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
againull
approved these changes
Apr 3, 2024
|
@intel/llvm-gatekeepers can we get this one merged? CI errors look unrelated to this change. |
|
Failed Tests (1): failure is unrelated and fixed in #13268 |
kbenzie
pushed a commit
to kbenzie/llvm
that referenced
this pull request
Apr 18, 2024
Add cubemap support: - Allocation and freeing of cubemapped images - Unsampled fetching and writing, and sampled reading - Device queries for cubemap support - Testing for both unsampled and sampled cubemap examples - Update the spec with cubemap support Remove `const` and `&` qualifiers from spec and implementation for handle parameters in `write_xxx` functions. Corresponding UR PR: oneapi-src/unified-runtime#1433 --------- Co-authored-by: Przemek Malon <przemek.malon@codeplay.com> Resolved Conflicts in: - Due to not cherry-picking intel#12840 - sycl/include/sycl/detail/pi.h - Due to not cherry-picking intel#13181 - sycl/include/sycl/device_aspect_macros.hpp - sycl/include/sycl/info/aspects.def
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add aspect to check for
sycl_ext_oneapi_private_allocaextension support. Only SPIR-V (OpenCL and Level Zero) devices have this aspect.In CodeGen, propagate this aspect when creating the
llvm.sycl.alloca.*intrinsic.In
sycl-post-link, do not assert on unsupported targets. Instead, assume the default value for the size specialization constant is used and handle the error at runtime. SPIR-V AOT compilation should fail in the frontend, so no need to fail here.