From aee6ee9c99a53eba15cb7832925c71155a798ef1 Mon Sep 17 00:00:00 2001 From: Andrei Elovikov Date: Wed, 8 May 2024 15:47:42 -0700 Subject: [PATCH] [SYCL] Use `-fno-discard-value-names` in relevant `check_device_code` tests `REQUIRES: asserts` was a wrong fix because that "feature" is never set/doesn't exist. --- sycl/test/check_device_code/group_load.cpp | 5 +---- sycl/test/check_device_code/vector/vector_math_ops.cpp | 4 +--- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/sycl/test/check_device_code/group_load.cpp b/sycl/test/check_device_code/group_load.cpp index 29e3292c0e5d6..d44c930ca678e 100644 --- a/sycl/test/check_device_code/group_load.cpp +++ b/sycl/test/check_device_code/group_load.cpp @@ -1,9 +1,6 @@ // NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --functions "group_load" --include-generated-funcs --version 4 // NOTE: and manually adjusted to follow the related explicit instantiation. -// RUN: %clangxx -O3 -fsycl -fsycl-device-only -S -emit-llvm -fno-sycl-instrument-device-code -o - %s | FileCheck %s - -// Generated checks have hard-coded basic block names, so need names in the IR. -// REQUIRES: asserts +// RUN: %clangxx -O3 -fsycl -fsycl-device-only -fno-discard-value-names -S -emit-llvm -fno-sycl-instrument-device-code -o - %s | FileCheck %s // Windows/linux have some slight differences in IR generation (function // arguments passing and long/long long differences/mangling) that could diff --git a/sycl/test/check_device_code/vector/vector_math_ops.cpp b/sycl/test/check_device_code/vector/vector_math_ops.cpp index 587382bb0b187..876fdd47101df 100644 --- a/sycl/test/check_device_code/vector/vector_math_ops.cpp +++ b/sycl/test/check_device_code/vector/vector_math_ops.cpp @@ -3,9 +3,7 @@ // ./llvm/utils/update_cc_test_checks.py --clang=./build/bin/clang // ./sycl/test/check_device_code/vector/vector_math_ops.cpp -// RUN: %clangxx -I %sycl_include -S -emit-llvm -fno-sycl-instrument-device-code -Xclang -disable-lifetime-markers -fsycl-device-only %s -o - | FileCheck %s - -// REQUIRES: asserts +// RUN: %clangxx -I %sycl_include -fno-discard-value-names -S -emit-llvm -fno-sycl-instrument-device-code -Xclang -disable-lifetime-markers -fsycl-device-only %s -o - | FileCheck %s // This test checks // (1) the storage type of sycl::vec on device for all data types, and