Skip to content

[SYCL][Joint Matrix][E2E] Add few load/store tests for different JointMatrixLoadStoreOpt flag setting #13873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 29, 2024
Merged

[SYCL][Joint Matrix][E2E] Add few load/store tests for different JointMatrixLoadStoreOpt flag setting #13873

merged 6 commits into from
May 29, 2024

Conversation

@YuriPlyakhin
Copy link
Contributor

@YuriPlyakhin YuriPlyakhin commented May 22, 2024 •
edited
Loading

This PR adds the following tests:

  • element_wise_all_ops verification for IGC_JointMatrixLoadStoreOpt=2,1,0. It is split to 3 different tests, since test runtime became too big, so splitting allows to run tests faster in several threads
  • big combinations, B row-major and annotated_ptr tests with different flag setting (IGC_JointMatrixLoadStoreOpt=0,1) in accordance with the loads/stores implemented in IGC for those flag settings.

@YuriPlyakhin YuriPlyakhin force-pushed the add_gather_scatter_load_store branch from 436f6bb to 0fea51f Compare May 22, 2024 21:44
@YuriPlyakhin YuriPlyakhin mentioned this pull request May 22, 2024
Closed
@YuriPlyakhin YuriPlyakhin changed the title Add gather scatter load store [SYCL][Joint Matrix][E2E] Add few load/store tests for different JointMatrixLoadStoreOpt flag setting May 22, 2024
@YuriPlyakhin YuriPlyakhin marked this pull request as ready for review May 23, 2024 15:15
@YuriPlyakhin YuriPlyakhin requested a review from a team as a code owner May 23, 2024 15:15
dkhaldi
dkhaldi reviewed May 27, 2024
View reviewed changes
dkhaldi
dkhaldi reviewed May 27, 2024
View reviewed changes
@YuriPlyakhin YuriPlyakhin force-pushed the add_gather_scatter_load_store branch from 0fea51f to 20c7bf3 Compare May 28, 2024 21:27
@YuriPlyakhin YuriPlyakhin requested a review from dkhaldi May 28, 2024 21:28
dkhaldi
dkhaldi approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@dkhaldi dkhaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YuriPlyakhin
Copy link
Contributor Author

YuriPlyakhin commented May 29, 2024

@intel/llvm-gatekeepers , all green, please merge

@steffenlarsen steffenlarsen merged commit dec1146 into intel:sycl May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkhaldi dkhaldi dkhaldi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@YuriPlyakhin @dkhaldi @steffenlarsen