Skip to content

[SYCL] Add a module flag for device compilations #13880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 31, 2024
Merged

[SYCL] Add a module flag for device compilations #13880

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fbb38c1
[SYCL] Add a module flag for device compilations
premanandrao May 21, 2024
6f46328
Fix space at EOL
premanandrao May 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions clang/lib/CodeGen/CodeGenModule.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1296,8 +1296,10 @@ void CodeGenModule::Release() {
getTarget().getTargetOpts().NVVMCudaPrecSqrt);
}

if (LangOpts.SYCLIsDevice && LangOpts.SYCLIsNativeCPU) {
getModule().addModuleFlag(llvm::Module::Error, "is-native-cpu", 1);
if (LangOpts.SYCLIsDevice) {
getModule().addModuleFlag(llvm::Module::Error, "sycl-device", 1);
if (LangOpts.SYCLIsNativeCPU)
getModule().addModuleFlag(llvm::Module::Error, "is-native-cpu", 1);
}

if (LangOpts.EHAsynch)
Expand Down
18 changes: 9 additions & 9 deletions clang/test/CodeGenSYCL/function-attrs.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
int foo();

// CHECK-LABEL: define linkonce_odr spir_func void @_Z3barv(
// CHECK-SAME: ) #[[ATTR2:[0-9]+]] !srcloc !5 {
// CHECK-SAME: ) #[[ATTR2:[0-9]+]] !srcloc ![[MD1:[0-9]+]] {
// CHECK-NEXT: entry:
// CHECK-NEXT: [[A:%.*]] = alloca i32, align 4
// CHECK-NEXT: [[A_ASCAST:%.*]] = addrspacecast ptr [[A]] to ptr addrspace(4)
Expand All @@ -18,7 +18,7 @@ void bar() {
}

// CHECK-LABEL: define linkonce_odr spir_func noundef i32 @_Z3foov(
// CHECK-SAME: ) #[[ATTR2]] !srcloc !6 {
// CHECK-SAME: ) #[[ATTR2]] !srcloc ![[MD2:[0-9]+]] {
// CHECK-NEXT: entry:
// CHECK-NEXT: [[RETVAL:%.*]] = alloca i32, align 4
// CHECK-NEXT: [[RETVAL_ASCAST:%.*]] = addrspacecast ptr [[RETVAL]] to ptr addrspace(4)
Expand All @@ -43,11 +43,11 @@ int main() {
// CHECK: attributes #2 = { convergent mustprogress noinline norecurse nounwind optnone "no-trapping-math"="true" "stack-protector-buffer-size"="8" }
// CHECK: attributes #3 = { convergent nounwind }
//.
// CHECK: !0 = !{i32 1, !"wchar_size", i32 4}
// CHECK: !1 = !{i32 1, i32 2}
// CHECK: !2 = !{i32 4, i32 100000}
// CHECK: !3 = !{i32 {{.*}}}
// CHECK: !4 = !{}
// CHECK: !5 = !{i32 {{.*}}}
// CHECK: !6 = !{i32 {{.*}}}
// CHECK: !{{[0-9]+}} = !{i32 1, !"wchar_size", i32 4}
// CHECK: !{{[0-9]+}} = !{i32 1, i32 2}
// CHECK: !{{[0-9]+}} = !{i32 4, i32 100000}
// CHECK: !{{[0-9]+}} = !{i32 {{.*}}}
// CHECK: !{{[0-9]+}} = !{}
// CHECK: ![[MD1]] = !{i32 {{.*}}}
// CHECK: ![[MD2]] = !{i32 {{.*}}}
//.
16 changes: 16 additions & 0 deletions clang/test/CodeGenSYCL/sycl-device-module-flag.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
// RUN: %clang_cc1 -fsycl-is-device -emit-llvm -internal-isystem %S/Inputs -o - %s | FileCheck %s
// RUN: %clang_cc1 -fsycl-is-host -emit-llvm -internal-isystem %S/Inputs -o - %s | FileCheck %s --check-prefixes=HOST

// This test checks if the sycl-device module flag is created for device
// compilations and not for host compilations.
#include "sycl.hpp"

void foo() {
sycl::handler h;
h.single_task([]() {});
}

// Check for the presence of sycl-device module flag in device
// compilations and its absence in host compilations.
// CHECK: !{{[0-9]*}} = !{i32 1, !"sycl-device", i32 1}
// HOST-NOT: !"sycl-device"