Skip to content

[SYCL][E2E] Use callable device selector in FilterSelector e2e tests #14162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 14, 2024
Merged

[SYCL][E2E] Use callable device selector in FilterSelector e2e tests #14162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
85fc5f8
Remove use of old device selectors
ayylol Jun 5, 2024
1e4521b
Merge branch 'sycl' into e2e-filterselector
ayylol Jun 13, 2024
ed39cc8
Remove unnecessary include in `select_device_cuda.cpp`
ayylol Jun 13, 2024
74c41af
clang format
ayylol Jun 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions sycl/test-e2e/FilterSelector/select_device_acc.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,35 +22,31 @@ int main() {
forcedPIs = envVal;
}
{
default_selector ds;
device d = ds.select_device();
device d(default_selector_v);
string name = d.get_platform().get_info<info::platform::name>();
assert(name.find("OpenCL") != string::npos &&
"default selector failed to find acc device");
}
{
gpu_selector gs;
try {
device d = gs.select_device();
device d(gpu_selector_v);
std::cerr << "GPU Device is found in error: " << std::boolalpha
<< d.is_gpu() << std::endl;
return -1;
} catch (...) {
}
}
{
cpu_selector cs;
try {
device d = cs.select_device();
device d(cpu_selector_v);
std::cerr << "CPU Device is found in error: " << std::boolalpha
<< d.is_cpu() << std::endl;
return -1;
} catch (...) {
}
}
{
accelerator_selector as;
device d = as.select_device();
device d(accelerator_selector_v);
string name = d.get_platform().get_info<info::platform::name>();
assert(name.find("OpenCL") != string::npos &&
"accelerator_selector failed to find acc device");
Expand Down
14 changes: 4 additions & 10 deletions sycl/test-e2e/FilterSelector/select_device_cpu.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,30 +22,24 @@ int main() {
forcedPIs = envVal;
}
{
default_selector ds;
device d = ds.select_device();
device d(default_selector_v);
string name = d.get_platform().get_info<info::platform::name>();
assert(name.find("OpenCL") != string::npos &&
"default_selector failed to find cpu device");
}
{
gpu_selector gs;
try {
device d = gs.select_device();
device d(gpu_selector_v);
std::cerr << "GPU Device is found: " << std::boolalpha << d.is_gpu()
<< std::endl;
return -1;
} catch (...) {
}
}
{ device d(cpu_selector_v); }
{
cpu_selector cs;
device d = cs.select_device();
}
{
accelerator_selector as;
try {
device d = as.select_device();
device d(accelerator_selector_v);
std::cerr << "ACC device is found in error: " << d.is_accelerator()
<< std::endl;
return -1;
Expand Down
12 changes: 4 additions & 8 deletions sycl/test-e2e/FilterSelector/select_device_cuda.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,30 +23,26 @@ int main() {
}

{
default_selector ds;
device d = ds.select_device();
device d(default_selector_v);
string name = d.get_platform().get_info<info::platform::name>();
assert(name.find("CUDA") != string::npos);
}
{
gpu_selector gs;
device d = gs.select_device();
device d(gpu_selector_v);
string name = d.get_platform().get_info<info::platform::name>();
assert(name.find("CUDA") != string::npos);
}
{
cpu_selector cs;
try {
device d = cs.select_device();
device d(cpu_selector_v);
cerr << "CPU device is found in error: " << d.is_cpu() << std::endl;
return -1;
} catch (...) {
}
}
{
accelerator_selector as;
try {
device d = as.select_device();
device d(accelerator_selector_v);
cerr << "ACC device is found in error: " << d.is_accelerator()
<< std::endl;
} catch (...) {
Expand Down