[NFCI] Remove/inline [rarely|never] used exception ctor overloads
#14406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SYCL 1.2 exception classes don't use `context` argument so it can be removed. `online_compile_error` was the single user of an overload, so I've removed it and change the ctor used by it.
aelovikov-intel
commented
Jul 2, 2024
| online_compile_error() = default; | ||
| online_compile_error(const std::string &Msg) : sycl::exception(Msg) {} | ||
| online_compile_error(const std::string &Msg) | ||
| : sycl::exception(make_error_code(errc::invalid), Msg) {} |
Contributor
Author
There was a problem hiding this comment.
See line 126 in the previous file on why I used this.
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
againull
approved these changes
Jul 2, 2024
bader
reviewed
Jul 2, 2024
Co-authored-by: Alexey Bader <alexey.bader@intel.com>
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SYCL 1.2 exception classes don't use
contextargument so it can be removed.online_compile_errorwas the single user of an overload, so I've removed it and change the ctor used by it.