From 3eb56b56f136c090c39057f65051a8308a0ae5ce Mon Sep 17 00:00:00 2001 From: Lorenc Bushi <113361374+lbushi25@users.noreply.github.com> Date: Mon, 15 Jul 2024 17:08:20 -0400 Subject: [PATCH 1/3] Have the spec say to throw a feature not supported error when a query is not supported --- .../supported/sycl_ext_intel_device_info.md | 26 +++++++++---------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/sycl/doc/extensions/supported/sycl_ext_intel_device_info.md b/sycl/doc/extensions/supported/sycl_ext_intel_device_info.md index d03444c3d49ee..0d96efd66fbef 100644 --- a/sycl/doc/extensions/supported/sycl_ext_intel_device_info.md +++ b/sycl/doc/extensions/supported/sycl_ext_intel_device_info.md @@ -46,7 +46,7 @@ A new aspect, ext\_intel\_device\_id, will be added. ## Error Condition ## -An invalid object runtime error will be thrown if the device does not support aspect\:\:ext\_intel\_device\_id. +An exception with a feature not supported error code will be thrown if the device does not support aspect\:\:ext\_intel\_device\_id. ## Example Usage ## @@ -83,7 +83,7 @@ A new aspect, ext\_intel\_device\_info\_uuid, will be added. ## Error Condition ## -An invalid object runtime error will be thrown if the device does not support aspect\:\:ext\_intel\_device\_info\_uuid. +An exception with a feature not supported error code will be thrown if the device does not support aspect\:\:ext\_intel\_device\_info\_uuid. ## Example Usage ## @@ -123,7 +123,7 @@ A new aspect, ext\_intel\_pci\_address, will be added. ## Error Condition ## -An invalid object runtime error will be thrown if the device does not support aspect\:\:ext\_intel\_pci\_address. +An exception with a feature not supported error code will be thrown if the device does not support aspect\:\:ext\_intel\_pci\_address. ## Example Usage ## @@ -162,7 +162,7 @@ A new aspect, ext\_intel\_gpu\_eu\_simd\_width, will be added. ## Error Condition ## -An invalid object runtime error will be thrown if the device does not support aspect\:\:ext\_intel\_gpu\_eu\_simd\_width. +An exception with a feature not supported error code will be thrown if the device does not support aspect\:\:ext\_intel\_gpu\_eu\_simd\_width. ## Example Usage ## @@ -202,7 +202,7 @@ A new aspect, ext\_intel\_gpu\_eu\_count, will be added. ## Error Condition ## -An invalid object runtime error will be thrown if the device does not support aspect\:\:ext\_intel\_gpu\_eu\_count. +An exception with a feature not supported error code will be thrown if the device does not support aspect\:\:ext\_intel\_gpu\_eu\_count. ## Example Usage ## @@ -238,7 +238,7 @@ A new aspect, ext\_intel\_gpu\_slices, will be added. ## Error Condition ## -An invalid object runtime error will be thrown if the device does not support aspect\:\:ext\_intel\_gpu\_slices. +An exception with a feature not supported error code will be thrown if the device does not support aspect\:\:ext\_intel\_gpu\_slices. ## Example Usage ## @@ -273,7 +273,7 @@ A new aspect, ext\_intel\_gpu\_subslices\_per\_slice, will be added. ## Error Condition ## -An invalid object runtime error will be thrown if the device does not support aspect\:\:ext\_intel\_gpu\_subslices\_per\_slice. +An exception with a feature not supported error code will be thrown if the device does not support aspect\:\:ext\_intel\_gpu\_subslices\_per\_slice. ## Example Usage ## @@ -308,7 +308,7 @@ A new aspect, ext\_intel\_gpu\_eu\_count\_per\_subslice, will be added. ## Error Condition ## -An invalid object runtime error will be thrown if the device does not support aspect\:\:ext\_intel\_gpu\_eu\_count\_per\_subslice. +An exception with a feature not supported error code will be thrown if the device does not support aspect\:\:ext\_intel\_gpu\_eu\_count\_per\_subslice. ## Example Usage ## @@ -341,7 +341,7 @@ A new aspect, ext\_intel\_gpu\_hw\_threads\_per\_eu, will be added. ## Error Condition ## -An invalid object runtime error will be thrown if the device does not support aspect\:\:ext\_intel\_gpu\_hw\_threads\_per\_eu. +An exception with a feature not supported error code will be thrown if the device does not support aspect\:\:ext\_intel\_gpu\_hw\_threads\_per\_eu. ## Example Usage ## @@ -377,7 +377,7 @@ A new aspect, ext\_intel\_max\_mem\_bandwidth, will be added. ## Error Condition ## -An invalid object runtime error will be thrown if the device does not support aspect\:\:ext\_intel\_max\_mem\_bandwidth. +An exception with a feature not supported error code will be thrown if the device does not support aspect\:\:ext\_intel\_max\_mem\_bandwidth. ## Example Usage ## @@ -415,7 +415,7 @@ A new aspect, ext\_intel\_free\_memory, will be added. ## Error Condition ## -An invalid object runtime error will be thrown if the device does not support aspect\:\:ext\_intel\_free\_memory. +An exception with a feature not supported error code will be thrown if the device does not support aspect\:\:ext\_intel\_free\_memory. ## Example Usage ## @@ -452,7 +452,7 @@ A new aspect, ext\_intel\_memory\_clock\_rate, is added. ## Error Condition ## -An invalid object runtime error is thrown if the device does not support aspect\:\:ext\_intel\_memory\_clock\_rate. +An exception with a feature not supported error code will be thrown if the device does not support aspect\:\:ext\_intel\_memory\_clock\_rate. ## Example Usage ## @@ -489,7 +489,7 @@ A new aspect, ext\_intel\_memory\_bus\_width, is added. ## Error Condition ## -An invalid object runtime error is thrown if the device does not support aspect\:\:ext\_intel\_memory\_bus\_width. +An exception with a feature not supported error code will be thrown if the device does not support aspect\:\:ext\_intel\_memory\_bus\_width. ## Example Usage ## From 003d5b1e6a07da11360ba9df619518e0c20c86c1 Mon Sep 17 00:00:00 2001 From: Lorenc Bushi <113361374+lbushi25@users.noreply.github.com> Date: Tue, 16 Jul 2024 10:36:14 -0400 Subject: [PATCH 2/3] Change wording Co-authored-by: Greg Lueck --- sycl/doc/extensions/supported/sycl_ext_intel_device_info.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sycl/doc/extensions/supported/sycl_ext_intel_device_info.md b/sycl/doc/extensions/supported/sycl_ext_intel_device_info.md index 0d96efd66fbef..c11b0c5244f2f 100644 --- a/sycl/doc/extensions/supported/sycl_ext_intel_device_info.md +++ b/sycl/doc/extensions/supported/sycl_ext_intel_device_info.md @@ -46,7 +46,8 @@ A new aspect, ext\_intel\_device\_id, will be added. ## Error Condition ## -An exception with a feature not supported error code will be thrown if the device does not support aspect\:\:ext\_intel\_device\_id. +Throws a synchronous `exception` with the `errc::feature_not_supported` error +code if the device does not have `aspect::ext_intel_device_id`. ## Example Usage ## From 0181a6064c6febe1bfbe8755763259e868070840 Mon Sep 17 00:00:00 2001 From: Lorenc Bushi <113361374+lbushi25@users.noreply.github.com> Date: Tue, 16 Jul 2024 10:42:41 -0400 Subject: [PATCH 3/3] Change wording --- .../supported/sycl_ext_intel_device_info.md | 27 +++++++++---------- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/sycl/doc/extensions/supported/sycl_ext_intel_device_info.md b/sycl/doc/extensions/supported/sycl_ext_intel_device_info.md index c11b0c5244f2f..d23beff4e8def 100644 --- a/sycl/doc/extensions/supported/sycl_ext_intel_device_info.md +++ b/sycl/doc/extensions/supported/sycl_ext_intel_device_info.md @@ -46,8 +46,7 @@ A new aspect, ext\_intel\_device\_id, will be added. ## Error Condition ## -Throws a synchronous `exception` with the `errc::feature_not_supported` error -code if the device does not have `aspect::ext_intel_device_id`. +Throws a synchronous `exception` with the `errc::feature_not_supported` error code if the device does not have `aspect::ext_intel_device_id`. ## Example Usage ## @@ -84,7 +83,7 @@ A new aspect, ext\_intel\_device\_info\_uuid, will be added. ## Error Condition ## -An exception with a feature not supported error code will be thrown if the device does not support aspect\:\:ext\_intel\_device\_info\_uuid. +Throws a synchronous `exception` with the `errc::feature_not_supported` error code if the device does not have `aspect::ext_intel_device_info_uuid`. ## Example Usage ## @@ -124,7 +123,7 @@ A new aspect, ext\_intel\_pci\_address, will be added. ## Error Condition ## -An exception with a feature not supported error code will be thrown if the device does not support aspect\:\:ext\_intel\_pci\_address. +Throws a synchronous `exception` with the `errc::feature_not_supported` error code if the device does not have `aspect::ext_intel_pci_address`. ## Example Usage ## @@ -163,7 +162,7 @@ A new aspect, ext\_intel\_gpu\_eu\_simd\_width, will be added. ## Error Condition ## -An exception with a feature not supported error code will be thrown if the device does not support aspect\:\:ext\_intel\_gpu\_eu\_simd\_width. +Throws a synchronous `exception` with the `errc::feature_not_supported` error code if the device does not have `aspect::ext_intel_gpu_eu_simd_width`. ## Example Usage ## @@ -203,7 +202,7 @@ A new aspect, ext\_intel\_gpu\_eu\_count, will be added. ## Error Condition ## -An exception with a feature not supported error code will be thrown if the device does not support aspect\:\:ext\_intel\_gpu\_eu\_count. +Throws a synchronous `exception` with the `errc::feature_not_supported` error code if the device does not have `aspect::ext_intel_gpu_eu_count`. ## Example Usage ## @@ -239,7 +238,7 @@ A new aspect, ext\_intel\_gpu\_slices, will be added. ## Error Condition ## -An exception with a feature not supported error code will be thrown if the device does not support aspect\:\:ext\_intel\_gpu\_slices. +Throws a synchronous `exception` with the `errc::feature_not_supported` error code if the device does not have `aspect::ext_intel_gpu_slices`. ## Example Usage ## @@ -274,7 +273,7 @@ A new aspect, ext\_intel\_gpu\_subslices\_per\_slice, will be added. ## Error Condition ## -An exception with a feature not supported error code will be thrown if the device does not support aspect\:\:ext\_intel\_gpu\_subslices\_per\_slice. +Throws a synchronous `exception` with the `errc::feature_not_supported` error code if the device does not have `aspect::ext_intel_gpu_subslices_per_slice`. ## Example Usage ## @@ -309,7 +308,7 @@ A new aspect, ext\_intel\_gpu\_eu\_count\_per\_subslice, will be added. ## Error Condition ## -An exception with a feature not supported error code will be thrown if the device does not support aspect\:\:ext\_intel\_gpu\_eu\_count\_per\_subslice. +Throws a synchronous `exception` with the `errc::feature_not_supported` error code if the device does not have `aspect::ext_intel_gpu_eu_count_per_subslice`. ## Example Usage ## @@ -342,7 +341,7 @@ A new aspect, ext\_intel\_gpu\_hw\_threads\_per\_eu, will be added. ## Error Condition ## -An exception with a feature not supported error code will be thrown if the device does not support aspect\:\:ext\_intel\_gpu\_hw\_threads\_per\_eu. +Throws a synchronous `exception` with the `errc::feature_not_supported` error code if the device does not have `aspect::ext_intel_gpu_hw_threads_per_eu`. ## Example Usage ## @@ -378,7 +377,7 @@ A new aspect, ext\_intel\_max\_mem\_bandwidth, will be added. ## Error Condition ## -An exception with a feature not supported error code will be thrown if the device does not support aspect\:\:ext\_intel\_max\_mem\_bandwidth. +Throws a synchronous `exception` with the `errc::feature_not_supported` error code if the device does not have `aspect::ext_intel_max_mem_bandwidth`. ## Example Usage ## @@ -416,7 +415,7 @@ A new aspect, ext\_intel\_free\_memory, will be added. ## Error Condition ## -An exception with a feature not supported error code will be thrown if the device does not support aspect\:\:ext\_intel\_free\_memory. +Throws a synchronous `exception` with the `errc::feature_not_supported` error code if the device does not have `aspect::ext_intel_free_memory`. ## Example Usage ## @@ -453,7 +452,7 @@ A new aspect, ext\_intel\_memory\_clock\_rate, is added. ## Error Condition ## -An exception with a feature not supported error code will be thrown if the device does not support aspect\:\:ext\_intel\_memory\_clock\_rate. +Throws a synchronous `exception` with the `errc::feature_not_supported` error code if the device does not have `aspect::ext_intel_memory_clock_rate`. ## Example Usage ## @@ -490,7 +489,7 @@ A new aspect, ext\_intel\_memory\_bus\_width, is added. ## Error Condition ## -An exception with a feature not supported error code will be thrown if the device does not support aspect\:\:ext\_intel\_memory\_bus\_width. +Throws a synchronous `exception` with the `errc::feature_not_supported` error code if the device does not have `aspect::ext_intel_memory_bus_width`. ## Example Usage ##