Skip to content

[SYCL][Test] Update ABI test after moving handler members to impl #14589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 17, 2024
Merged

[SYCL][Test] Update ABI test after moving handler members to impl #14589

merged 3 commits into from
Jul 17, 2024

Conversation

@againull
Copy link
Contributor

@againull againull commented Jul 16, 2024 •
edited
Loading

  • 14460 moved handler members to impl and basically fixed exclusions we had in this test.
  • Also match "struct" as well, not only "class", these resulted in several new hits but those doesn't seem to cross ABI boundary, because they are compile-time properties fully processed in the headers.

@againull againull requested a review from a team as a code owner July 16, 2024 18:51
@againull againull requested a review from bso-intel July 16, 2024 18:51
steffenlarsen
steffenlarsen approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@steffenlarsen
Fix new_allocator naming
e0e73f6 
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
@Seanst98 Seanst98 mentioned this pull request Jul 17, 2024
Merged
@sergey-semenov sergey-semenov mentioned this pull request Jul 17, 2024
Merged
@steffenlarsen steffenlarsen merged commit d7868e8 into intel:sycl Jul 17, 2024
@ianayl ianayl mentioned this pull request Jul 17, 2024
Merged
@againull againull deleted the update_abi_test branch August 7, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@steffenlarsen steffenlarsen steffenlarsen approved these changes

@bso-intel bso-intel Awaiting requested review from bso-intel bso-intel is a code owner automatically assigned from intel/llvm-reviewers-runtime

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@againull @steffenlarsen