From f1d5baf3c4141e0f090637882a922ad97d679fe2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Peter=20=C5=BDu=C5=BEek?= Date: Mon, 5 Aug 2024 15:01:05 +0100 Subject: [PATCH 1/2] [SYCL][Bindless] Bump to revision 6 * Bump revision number * Increase value of `SYCL_EXT_ONEAPI_BINDLESS_IMAGES` --- .../sycl_ext_oneapi_bindless_images.asciidoc | 14 +++++++++----- sycl/source/feature_test.hpp.in | 2 +- sycl/test-e2e/bindless_images/sampling_1D.cpp | 2 +- 3 files changed, 11 insertions(+), 7 deletions(-) diff --git a/sycl/doc/extensions/experimental/sycl_ext_oneapi_bindless_images.asciidoc b/sycl/doc/extensions/experimental/sycl_ext_oneapi_bindless_images.asciidoc index 7218217298237..2f7e422555540 100644 --- a/sycl/doc/extensions/experimental/sycl_ext_oneapi_bindless_images.asciidoc +++ b/sycl/doc/extensions/experimental/sycl_ext_oneapi_bindless_images.asciidoc @@ -114,11 +114,13 @@ implementation supports. [frame="none",options="header"] |====================== -|Rev |Description -|1 |Initial draft of the proposal -|2 |Second revision of the proposal -|3 |Third revision of the proposal -|4 |Fourth revision of the proposal +|Rev | Description +|1 | Initial draft of the proposal +|2 | Second revision of the proposal +|3 | Third revision of the proposal +|4 | Fourth revision of the proposal +|5 | Fifth revision of the proposal +|6 | Sixth revision of the proposal |====================== See the revision history at the bottom of this document for features added in @@ -2884,4 +2886,6 @@ These features still need to be handled: handles and the imported `interop_xxx_handle`. |5.17|2024-07-30| - Add support for mapping external memory to linear USM using `map_external_linear_memory`. +|6 |2024-08-05 | - Collated all changes since revision 5. + - Bumped SYCL_EXT_ONEAPI_BINDLESS_IMAGES to number 6. |====================== diff --git a/sycl/source/feature_test.hpp.in b/sycl/source/feature_test.hpp.in index d3724c49bad7e..2bb13420df4a6 100644 --- a/sycl/source/feature_test.hpp.in +++ b/sycl/source/feature_test.hpp.in @@ -40,7 +40,7 @@ inline namespace _V1 { #define SYCL_EXT_ONEAPI_QUEUE_PRIORITY 1 #define SYCL_EXT_ONEAPI_ENQUEUE_BARRIER 1 #define SYCL_EXT_ONEAPI_FREE_FUNCTION_QUERIES 1 -#define SYCL_EXT_ONEAPI_BINDLESS_IMAGES 1 +#define SYCL_EXT_ONEAPI_BINDLESS_IMAGES 6 #define SYCL_EXT_ONEAPI_GROUP_ALGORITHMS 1 #define SYCL_EXT_ONEAPI_GROUP_SORT 2 #define SYCL_EXT_ONEAPI_KERNEL_COMPILER 1 diff --git a/sycl/test-e2e/bindless_images/sampling_1D.cpp b/sycl/test-e2e/bindless_images/sampling_1D.cpp index e8f38cabf4db4..3342e4ae2215f 100644 --- a/sycl/test-e2e/bindless_images/sampling_1D.cpp +++ b/sycl/test-e2e/bindless_images/sampling_1D.cpp @@ -15,7 +15,7 @@ class image_addition; int main() { #if defined(SYCL_EXT_ONEAPI_BINDLESS_IMAGES) - assert(SYCL_EXT_ONEAPI_BINDLESS_IMAGES == 1); + assert(SYCL_EXT_ONEAPI_BINDLESS_IMAGES == 6); #if defined(VERBOSE_PRINT) std::cout << "SYCL_EXT_ONEAPI_BINDLESS_IMAGES is defined!" << std::endl; #endif From 81c469116b2c33ba1a8570ce6cc74c2d559d54a3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Peter=20=C5=BDu=C5=BEek?= Date: Mon, 19 Aug 2024 10:22:03 +0100 Subject: [PATCH 2/2] Fix revision history table formatting --- .../experimental/sycl_ext_oneapi_bindless_images.asciidoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sycl/doc/extensions/experimental/sycl_ext_oneapi_bindless_images.asciidoc b/sycl/doc/extensions/experimental/sycl_ext_oneapi_bindless_images.asciidoc index 2f7e422555540..4b0217877c46f 100644 --- a/sycl/doc/extensions/experimental/sycl_ext_oneapi_bindless_images.asciidoc +++ b/sycl/doc/extensions/experimental/sycl_ext_oneapi_bindless_images.asciidoc @@ -2871,7 +2871,7 @@ These features still need to be handled: funcs. |5.14|2024-07-17| - Rename `destroy_external_semaphore` to `release_external_semaphore`. -|5.15|2024-07-19 - Add missing device queries for image arrays, sampling USM +|5.15|2024-07-19| - Add missing device queries for image arrays, sampling USM images and unique addressing per dimension. - Remove aspects for semaphore export, memory export and fetch 3D USM images as they are not supported on any platform.