Skip to content

[SYCL][Bindless] Bump to revision 6 #14953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 29, 2024
Merged

[SYCL][Bindless] Bump to revision 6 #14953

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f1d5baf
[SYCL][Bindless] Bump to revision 6
ProGTX Aug 5, 2024
81c4691
Fix revision history table formatting
ProGTX Aug 19, 2024
526c722
Merge branch 'sycl' into peter/bindless-rev6
ProGTX Aug 22, 2024
b9027b3
Merge 'sycl' into peter/bindless-rev6
ProGTX Aug 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions sycl/doc/extensions/experimental/sycl_ext_oneapi_bindless_images.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,11 +114,13 @@ implementation supports.

[frame="none",options="header"]
|======================
|Rev |Description
|1 |Initial draft of the proposal
|2 |Second revision of the proposal
|3 |Third revision of the proposal
|4 |Fourth revision of the proposal
|Rev | Description
|1 | Initial draft of the proposal
|2 | Second revision of the proposal
|3 | Third revision of the proposal
|4 | Fourth revision of the proposal
|5 | Fifth revision of the proposal
|6 | Sixth revision of the proposal
|======================

See the revision history at the bottom of this document for features added in
Expand Down Expand Up @@ -2869,7 +2871,7 @@ These features still need to be handled:
funcs.
|5.14|2024-07-17| - Rename `destroy_external_semaphore` to
`release_external_semaphore`.
|5.15|2024-07-19 - Add missing device queries for image arrays, sampling USM
|5.15|2024-07-19| - Add missing device queries for image arrays, sampling USM
images and unique addressing per dimension.
- Remove aspects for semaphore export, memory export and fetch
3D USM images as they are not supported on any platform.
Expand All @@ -2884,4 +2886,6 @@ These features still need to be handled:
handles and the imported `interop_xxx_handle`.
|5.17|2024-07-30| - Add support for mapping external memory to linear USM using
`map_external_linear_memory`.
|6 |2024-08-05 | - Collated all changes since revision 5.
- Bumped SYCL_EXT_ONEAPI_BINDLESS_IMAGES to number 6.
|======================
2 changes: 1 addition & 1 deletion sycl/source/feature_test.hpp.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ inline namespace _V1 {
#define SYCL_EXT_ONEAPI_QUEUE_PRIORITY 1
#define SYCL_EXT_ONEAPI_ENQUEUE_BARRIER 1
#define SYCL_EXT_ONEAPI_FREE_FUNCTION_QUERIES 1
#define SYCL_EXT_ONEAPI_BINDLESS_IMAGES 1
#define SYCL_EXT_ONEAPI_BINDLESS_IMAGES 6
#define SYCL_EXT_ONEAPI_GROUP_ALGORITHMS 1
#define SYCL_EXT_ONEAPI_GROUP_SORT 2
#define SYCL_EXT_ONEAPI_KERNEL_COMPILER 1
Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/bindless_images/sampling_1D.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ class image_addition;
int main() {

#if defined(SYCL_EXT_ONEAPI_BINDLESS_IMAGES)
assert(SYCL_EXT_ONEAPI_BINDLESS_IMAGES == 1);
assert(SYCL_EXT_ONEAPI_BINDLESS_IMAGES == 6);
#if defined(VERBOSE_PRINT)
std::cout << "SYCL_EXT_ONEAPI_BINDLESS_IMAGES is defined!" << std::endl;
#endif
Expand Down