From b553b51bffe264a4f6c64f8fbe7d251c0e27571f Mon Sep 17 00:00:00 2001 From: "Larsen, Steffen" Date: Fri, 16 Aug 2024 06:53:50 -0700 Subject: [PATCH] [SYCL][E2E] Remove leaking part of non-uniform-wk-gp-test As shown in https://github.com/intel/llvm/issues/15111, currently sycl::stream will leak resources if an exception is thrown during launch of its associated command. This was in turn causing sycl/test-e2e/Basic/diagnostics/non-uniform-wk-gp-test.cpp to leak resources simply because it was using the stream in its testing. However, since the kernel should never execute, the stream did not serve a fundamental function in the test and was only there for additional debugging information in the case where the test would fail. As such, it is arguably better to improve coverage than to disable cases because of some potentially helpful additional output in the failing case. Signed-off-by: Larsen, Steffen --- sycl/test-e2e/Basic/diagnostics/non-uniform-wk-gp-test.cpp | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/sycl/test-e2e/Basic/diagnostics/non-uniform-wk-gp-test.cpp b/sycl/test-e2e/Basic/diagnostics/non-uniform-wk-gp-test.cpp index 8b613b7878855..678d7a0bb0010 100644 --- a/sycl/test-e2e/Basic/diagnostics/non-uniform-wk-gp-test.cpp +++ b/sycl/test-e2e/Basic/diagnostics/non-uniform-wk-gp-test.cpp @@ -3,7 +3,6 @@ // RUN: %{build} -o %t.out // RUN: %{run} %t.out -// UNSUPPORTED: ze_debug //==------- non-uniform-wk-gp-test.cpp -------==// // This is a diagnostic test which verifies that // for loops with non-uniform work groups size @@ -12,7 +11,6 @@ #include #include -#include using namespace sycl; @@ -26,12 +24,9 @@ int test() { try { const int N = 1; q.submit([&](handler &cgh) { - sycl::stream kernelout(108 * 64 + 128, 64, cgh); cgh.parallel_for( nd_range<3>(range<3>{1, 1, N}, range<3>{1, 1, 16}), - [=](nd_item<3> itm) { - kernelout << "Coordinates: " << itm.get_global_id() << sycl::endl; - }); + [=](nd_item<3> itm) {}); }); std::cout << "Test failed: no exception thrown." << std::endl; } catch (exception &E) {