Skip to content

[NFC][SYCL] Remove dead code from queue_impl.hpp #15417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2024
Merged

[NFC][SYCL] Remove dead code from queue_impl.hpp #15417

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions sycl/source/detail/queue_impl.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -689,15 +689,9 @@ class queue_impl {
std::vector<event> &MutableVec,
std::unique_lock<std::mutex> &QueueLock);

// Helps to manage host tasks presence in scenario with barrier usage.
// Approach that tracks almost all tasks to provide barrier sync for both ur
// tasks and host tasks is applicable for out of order queues only. No-op
// for in order ones.
void tryToResetEnqueuedBarrierDep(const EventImplPtr &EnqueuedBarrierEvent);

// Called on host task completion that could block some kernels from enqueue.
// Approach that tracks almost all tasks to provide barrier sync for both ur
// tasks and host tasks is applicable for out of order queues only. Not neede
// tasks and host tasks is applicable for out of order queues only. Not needed
// for in order ones.
void revisitUnenqueuedCommandsState(const EventImplPtr &CompletedHostTask);

Expand Down