Skip to content

[SYCL] Add ext::intel::info::device::device_id to sycl-ls output #15689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 16, 2024
Merged

[SYCL] Add ext::intel::info::device::device_id to sycl-ls output #15689

merged 10 commits into from
Oct 16, 2024

Conversation

dyniols
Copy link
Contributor

@dyniols dyniols commented Oct 14, 2024 •
edited
Loading

The purpose of this change is to allow to mark with // XFAIL: gpu-intel-pvc-1T tests that are still failing exclusively on PVC T1.
In this change, new information about the device_id was added to sycl-ls --verbose if device id is available.

@dyniols dyniols changed the title [SYCL] Skip failing tests for PVC T1 [SYCL] sycl-ls change to allow detect PVC T1 Oct 15, 2024
@dyniols dyniols changed the title [SYCL] sycl-ls change to allow detect PVC T1 [SYCL] sycl-ls change to allow detect specific PVC type Oct 15, 2024
@dyniols dyniols changed the title [SYCL] sycl-ls change to allow detect specific PVC type [SYCL] sycl-ls change to allow detection of specific PVC type Oct 15, 2024
@dyniols dyniols marked this pull request as ready for review October 15, 2024 08:51
@dyniols dyniols requested review from a team as code owners October 15, 2024 08:51
@dyniols dyniols requested a review from maarquitos14 October 15, 2024 08:51
maarquitos14
maarquitos14 reviewed Oct 15, 2024
View reviewed changes
Copy link
Contributor

@maarquitos14 maarquitos14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add gpu-intel-pvc-2T?

@dyniols
Copy link
Contributor Author

dyniols commented Oct 15, 2024

Should we also add gpu-intel-pvc-2T?

I added just in case.

@dyniols dyniols requested a review from AlexeySachkov October 15, 2024 10:49
@aelovikov-intel aelovikov-intel changed the title [SYCL] sycl-ls change to allow detection of specific PVC type [SYCL] Add ext::intel::info::device::device_id to sycl-ls output Oct 15, 2024
@AlexeySachkov AlexeySachkov merged commit dcb975d into intel:sycl Oct 16, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maarquitos14 maarquitos14 maarquitos14 approved these changes

@aarongreig aarongreig aarongreig approved these changes

@AlexeySachkov AlexeySachkov Awaiting requested review from AlexeySachkov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dyniols @AlexeySachkov @maarquitos14 @aarongreig