From 3e5f870c519cac9754befd12e5bb9acd80633a45 Mon Sep 17 00:00:00 2001 From: "Zhao, Yang2" Date: Tue, 5 Nov 2024 22:54:11 -0800 Subject: [PATCH 1/3] enable private_nullptr --- .../AddressSanitizer/nullpointer/private_nullptr.cpp | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/sycl/test-e2e/AddressSanitizer/nullpointer/private_nullptr.cpp b/sycl/test-e2e/AddressSanitizer/nullpointer/private_nullptr.cpp index 6b013a2aee1e2..4ac02b8d32343 100644 --- a/sycl/test-e2e/AddressSanitizer/nullpointer/private_nullptr.cpp +++ b/sycl/test-e2e/AddressSanitizer/nullpointer/private_nullptr.cpp @@ -6,9 +6,6 @@ // RUN: %{build} %device_asan_flags -O2 -g -o %t3.out // RUN: %{run} not %t3.out 2>&1 | FileCheck %s -// FIXME: There's an issue in gfx driver, so this test pending here. -// XFAIL: * - #include #include @@ -22,15 +19,14 @@ int main() { sycl::nd_range<1>(N, 1), [=](sycl::nd_item<1> item) { auto private_array = sycl::ext::oneapi::experimental::static_address_cast< - sycl::access::address_space::private_space, - sycl::access::decorated::no>(array); + sycl::access::address_space::private_space>(array); private_array[0] = 0; }); Q.wait(); }); // CHECK: ERROR: DeviceSanitizer: null-pointer-access on Unknown Memory // CHECK: WRITE of size 4 at kernel {{<.*MyKernel>}} LID(0, 0, 0) GID({{.*}}, 0, 0) - // CHECK: {{.*private_nullptr.cpp}}:[[@LINE-5]] + // CHECK: {{.*private_nullptr.cpp}}:[[@LINE-6]] return 0; } From 3c4653acd9fa0789da3ad4d9dbeaffbdee3b8d8f Mon Sep 17 00:00:00 2001 From: "Zhao, Yang2" Date: Thu, 14 Nov 2024 00:17:09 -0800 Subject: [PATCH 2/3] update tracker --- sycl/test/e2e_test_requirements/no-xfail-without-tracker.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/sycl/test/e2e_test_requirements/no-xfail-without-tracker.cpp b/sycl/test/e2e_test_requirements/no-xfail-without-tracker.cpp index c51900eb5fae9..6d16728ee43ce 100644 --- a/sycl/test/e2e_test_requirements/no-xfail-without-tracker.cpp +++ b/sycl/test/e2e_test_requirements/no-xfail-without-tracker.cpp @@ -51,13 +51,12 @@ // tests to match the required format and in that case you should just update // (i.e. reduce) the number and the list below. // -// NUMBER-OF-XFAIL-WITHOUT-TRACKER: 156 +// NUMBER-OF-XFAIL-WITHOUT-TRACKER: 155 // // List of improperly XFAIL-ed tests. // Remove the CHECK once the test has been propely XFAIL-ed. // -// CHECK: AddressSanitizer/nullpointer/private_nullptr.cpp -// CHECK-NEXT: Basic/accessor/accessor.cpp +// CHECK: Basic/accessor/accessor.cpp // CHECK-NEXT: Basic/aspects.cpp // CHECK-NEXT: Basic/buffer/reinterpret.cpp // CHECK-NEXT: Basic/built-ins.cpp From f17bbfb5c621ca76cfab4c5b2e8a59a4144427d2 Mon Sep 17 00:00:00 2001 From: "Zhao, Yang2" Date: Thu, 14 Nov 2024 00:58:19 -0800 Subject: [PATCH 3/3] fix tracker --- sycl/test/e2e_test_requirements/no-xfail-without-tracker.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sycl/test/e2e_test_requirements/no-xfail-without-tracker.cpp b/sycl/test/e2e_test_requirements/no-xfail-without-tracker.cpp index 1c3f0397a8808..dbf8dac7112b3 100644 --- a/sycl/test/e2e_test_requirements/no-xfail-without-tracker.cpp +++ b/sycl/test/e2e_test_requirements/no-xfail-without-tracker.cpp @@ -56,8 +56,7 @@ // List of improperly XFAIL-ed tests. // Remove the CHECK once the test has been properly XFAIL-ed. // -// CHECK: Basic/accessor/accessor.cpp -// CHECK-NEXT: Basic/aspects.cpp +// CHECK: Basic/aspects.cpp // CHECK-NEXT: Basic/buffer/reinterpret.cpp // CHECK-NEXT: Basic/device_event.cpp // CHECK-NEXT: Basic/diagnostics/handler.cpp