From e5436bf63a5c3227d5618de9b4b166a0a3f67083 Mon Sep 17 00:00:00 2001 From: "Kornev, Nikita" Date: Fri, 8 Nov 2024 07:06:54 -0800 Subject: [PATCH 1/5] [SYCL][E2E] Add test to track RUNx tests The same idea as for XFAIL and UNSUPPORTED. The test checks if there is a RUNx without tracker. Also: - this PR also updates some RUNx tests as they are likely fixed. - marks some as UNSUPPORTED as there is only one RUNx line. - adds tracker for the rest. After that there shouldn't be any untracked RUNx tests in sycl/test-e2e. --- .../Basic/fpga_tests/fpga_io_pipes.cpp | 9 +++--- .../Graph/Explicit/host_task_last.cpp | 2 +- .../Graph/RecordReplay/host_task_last.cpp | 2 +- .../OptionalKernelFeatures/fp64-conv-emu.cpp | 3 +- sycl/test-e2e/Regression/isordered.cpp | 2 +- sycl/test-e2e/Regression/mad_sat.cpp | 2 +- sycl/test-e2e/SharedLib/use_with_dlopen.cpp | 1 + .../use_with_dlopen_verify_cache.cpp | 1 + .../no-runx-without-tracker.cpp | 29 +++++++++++++++++++ .../no-unsupported-without-info.cpp | 3 +- 10 files changed, 43 insertions(+), 11 deletions(-) create mode 100644 sycl/test/e2e_test_requirements/no-runx-without-tracker.cpp diff --git a/sycl/test-e2e/Basic/fpga_tests/fpga_io_pipes.cpp b/sycl/test-e2e/Basic/fpga_tests/fpga_io_pipes.cpp index ed6ff3fc6dccb..6d2707fc01d82 100644 --- a/sycl/test-e2e/Basic/fpga_tests/fpga_io_pipes.cpp +++ b/sycl/test-e2e/Basic/fpga_tests/fpga_io_pipes.cpp @@ -1,6 +1,10 @@ +// The test is disabled, since no support added in FPGA backend yet. Check +// implementation correctness from CXX and SYCL languages perspective. +// UNSUPPORTED: true + // REQUIRES: accelerator // RUN: %{build} -o %t.out -// RUNx: %{run} %t.out +// RUN: %{run} %t.out //==------------ fpga_io_pipes.cpp - SYCL FPGA pipes test ------------------==// // // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. @@ -15,9 +19,6 @@ #include "io_pipe_def.h" -// TODO: run is disabled, since no support added in FPGA backend yet. Check -// implementation correctness from CXX and SYCL languages perspective. - // This test is supposed to be run only on Intel FPGA emulator. Change it when // we have more experience with IO pipe feature in SYCL. // The emulator creates files (one for I pipe, another for O pipe) with the diff --git a/sycl/test-e2e/Graph/Explicit/host_task_last.cpp b/sycl/test-e2e/Graph/Explicit/host_task_last.cpp index fe078facd4fae..7dae93ab2c23f 100644 --- a/sycl/test-e2e/Graph/Explicit/host_task_last.cpp +++ b/sycl/test-e2e/Graph/Explicit/host_task_last.cpp @@ -3,9 +3,9 @@ // Extra run to check for leaks in Level Zero using UR_L0_LEAKS_DEBUG // RUN: %if level_zero %{env SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=0 %{l0_leak_check} %{run} %t.out 2>&1 | FileCheck %s --implicit-check-not=LEAK %} -// Disabled due to https://github.com/intel/llvm/issues/14473 // Extra run to check for immediate-command-list in Level Zero // RUNx: %if level_zero %{env SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=1 %{l0_leak_check} %{run} %t.out 2>&1 | FileCheck %s --implicit-check-not=LEAK %} +// RUNx-TRACKER: https://github.com/intel/llvm/issues/14473 // REQUIRES: aspect-usm_shared_allocations diff --git a/sycl/test-e2e/Graph/RecordReplay/host_task_last.cpp b/sycl/test-e2e/Graph/RecordReplay/host_task_last.cpp index 450ab65d05942..bf1817bc1c09f 100644 --- a/sycl/test-e2e/Graph/RecordReplay/host_task_last.cpp +++ b/sycl/test-e2e/Graph/RecordReplay/host_task_last.cpp @@ -3,9 +3,9 @@ // Extra run to check for leaks in Level Zero using UR_L0_LEAKS_DEBUG // RUN: %if level_zero %{env SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=0 %{l0_leak_check} %{run} %t.out 2>&1 | FileCheck %s --implicit-check-not=LEAK %} -// Disabled due to https://github.com/intel/llvm/issues/14473 // Extra run to check for immediate-command-list in Level Zero // RUNx: %if level_zero %{env SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=1 %{l0_leak_check} %{run} %t.out 2>&1 | FileCheck %s --implicit-check-not=LEAK %} +// RUNx-TRACKER: https://github.com/intel/llvm/issues/14473 // REQUIRES: aspect-usm_shared_allocations diff --git a/sycl/test-e2e/OptionalKernelFeatures/fp64-conv-emu.cpp b/sycl/test-e2e/OptionalKernelFeatures/fp64-conv-emu.cpp index 5094a1d0af48f..237a049c80f3d 100644 --- a/sycl/test-e2e/OptionalKernelFeatures/fp64-conv-emu.cpp +++ b/sycl/test-e2e/OptionalKernelFeatures/fp64-conv-emu.cpp @@ -2,8 +2,7 @@ // UNSUPPORTED: cuda, hip // RUN: %clangxx -fsycl -fsycl-targets=spir64_gen -Xsycl-target-backend "-device pvc" -fsycl-fp64-conv-emu -O0 %s -o %t_opt.out -// TODO: Enable when GPU driver is updated. -// RUNx: %{run} %t_opt.out +// RUN: %{run} %t_opt.out // Tests that aspect::fp64 is not emitted correctly when -fsycl-fp64-conv-emu // flag is used. diff --git a/sycl/test-e2e/Regression/isordered.cpp b/sycl/test-e2e/Regression/isordered.cpp index 7d3d0d32b688c..4b4d18b93896e 100644 --- a/sycl/test-e2e/Regression/isordered.cpp +++ b/sycl/test-e2e/Regression/isordered.cpp @@ -1,5 +1,5 @@ // RUN: %{build} -o %t.out -// RUNx: %{run} %t.out +// RUN: %{run} %t.out #include diff --git a/sycl/test-e2e/Regression/mad_sat.cpp b/sycl/test-e2e/Regression/mad_sat.cpp index 401a2644d1743..964997171672f 100644 --- a/sycl/test-e2e/Regression/mad_sat.cpp +++ b/sycl/test-e2e/Regression/mad_sat.cpp @@ -1,5 +1,5 @@ // RUN: %{build} -Wno-error=integer-overflow -Wno-error=implicitly-unsigned-literal -o %t.out -// RUNx: %{run} %t.out +// RUN: %{run} %t.out #include diff --git a/sycl/test-e2e/SharedLib/use_with_dlopen.cpp b/sycl/test-e2e/SharedLib/use_with_dlopen.cpp index b904b8c3b1aa0..460d056dbb0d2 100644 --- a/sycl/test-e2e/SharedLib/use_with_dlopen.cpp +++ b/sycl/test-e2e/SharedLib/use_with_dlopen.cpp @@ -16,6 +16,7 @@ // This causes SEG. FAULT. // RUNx: %{compile} -o %t4.out -DRUN_LAST // RUNx: %{run} %t4.out +// RUNx-TRACKER: https://github.com/intel/llvm/issues/16031 #include diff --git a/sycl/test-e2e/SharedLib/use_with_dlopen_verify_cache.cpp b/sycl/test-e2e/SharedLib/use_with_dlopen_verify_cache.cpp index fcc50a6acaaf4..d0df39df16dbe 100644 --- a/sycl/test-e2e/SharedLib/use_with_dlopen_verify_cache.cpp +++ b/sycl/test-e2e/SharedLib/use_with_dlopen_verify_cache.cpp @@ -17,6 +17,7 @@ // This causes SEG. FAULT. // RUNx: %{compile} -DRUN_LAST // RUNx: env SYCL_UR_TRACE=2 %{run} %t.out 2>&1 | FileCheck %s --check-prefixes=CHECK-LAST,CHECK --implicit-check-not=piProgramBuild +// RUNx-TRACKER: https://github.com/intel/llvm/issues/16031 // clang-format on #include diff --git a/sycl/test/e2e_test_requirements/no-runx-without-tracker.cpp b/sycl/test/e2e_test_requirements/no-runx-without-tracker.cpp new file mode 100644 index 0000000000000..08326f47dd02f --- /dev/null +++ b/sycl/test/e2e_test_requirements/no-runx-without-tracker.cpp @@ -0,0 +1,29 @@ +// This test is intended to ensure that we have no tests marked as RUNx +// without a tracker information added to a test. If it fails - please create +// a tracker for RUNx-marked test. +// +// The format we check is: +// RUNx: command +// RUNx-TRACKER: [GitHub issue URL|Internal tracker ID] +// +// GitHub issue URL format: +// https://github.com/owner/repo/issues/12345 +// +// Internal tracker ID format: +// PROJECT-123456 +// +// REQUIRES: linux +// +// Explanation of the command: +// - search for all "RUNx" occurrences, display line with match and the next one +// -I, --include to drop binary files and other unrelated files +// - in the result, search for "RUNx" again, but invert the result - this +// allows us to get the line *after* RUNx +// - in those lines, check that RUNx-TRACKER is present and correct. Once +// again, invert the search to get all "bad" lines; running it with "not" as +// grep exits with 1 if it finds nothing +// +// RUN: grep -rI "RUNx:" %S/../../test-e2e \ +// RUN: -A 1 --include=*.cpp --no-group-separator | \ +// RUN: grep -v "RUNx:" | \ +// RUN: not grep -Pv "RUNx-TRACKER:\s+(?:https://github.com/[\w\d-]+/[\w\d-]+/issues/[\d]+)|(?:[\w]+-[\d]+)" diff --git a/sycl/test/e2e_test_requirements/no-unsupported-without-info.cpp b/sycl/test/e2e_test_requirements/no-unsupported-without-info.cpp index 3602d7d01ae95..0d01b64415d89 100644 --- a/sycl/test/e2e_test_requirements/no-unsupported-without-info.cpp +++ b/sycl/test/e2e_test_requirements/no-unsupported-without-info.cpp @@ -54,7 +54,7 @@ // tests to match the required format and in that case you should just update // (i.e. reduce) the number and the list below. // -// NUMBER-OF-UNSUPPORTED-WITHOUT-INFO: 477 +// NUMBER-OF-UNSUPPORTED-WITHOUT-INFO: 478 // // List of improperly UNSUPPORTED tests. // Remove the CHECK once the test has been properly UNSUPPORTED. @@ -77,6 +77,7 @@ // CHECK-NEXT: Basic/buffer/subbuffer.cpp // CHECK-NEXT: Basic/build_log.cpp // CHECK-NEXT: Basic/code_location_e2e.cpp +// CHECK-NEXT: Basic/fpga_tests/fpga_io_pipes.cpp // CHECK-NEXT: Basic/free_function_queries/free_function_queries.cpp // CHECK-NEXT: Basic/free_function_queries/free_function_queries_sub_group.cpp // CHECK-NEXT: Basic/free_function_queries/free_function_queries_sub_group.cpp From 38f5b3e97bb8c75817133cc727206a8043e293ed Mon Sep 17 00:00:00 2001 From: "Kornev, Nikita" Date: Mon, 11 Nov 2024 06:25:25 -0800 Subject: [PATCH 2/5] format --- sycl/test/e2e_test_requirements/no-runx-without-tracker.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sycl/test/e2e_test_requirements/no-runx-without-tracker.cpp b/sycl/test/e2e_test_requirements/no-runx-without-tracker.cpp index 08326f47dd02f..fcea2bfd87bfc 100644 --- a/sycl/test/e2e_test_requirements/no-runx-without-tracker.cpp +++ b/sycl/test/e2e_test_requirements/no-runx-without-tracker.cpp @@ -26,4 +26,4 @@ // RUN: grep -rI "RUNx:" %S/../../test-e2e \ // RUN: -A 1 --include=*.cpp --no-group-separator | \ // RUN: grep -v "RUNx:" | \ -// RUN: not grep -Pv "RUNx-TRACKER:\s+(?:https://github.com/[\w\d-]+/[\w\d-]+/issues/[\d]+)|(?:[\w]+-[\d]+)" +// RUN: not grep -Pv "RUNx-TRACKER:\s+(?:https://github.com/[\w\d-]+/[\w\d-]+/issues/[\d]+)|(?:[\w]+-[\d]+)" From 0e9e0557b52770355affc10e14e24b34a0427e39 Mon Sep 17 00:00:00 2001 From: "Kornev, Nikita" Date: Mon, 11 Nov 2024 06:12:44 -0800 Subject: [PATCH 3/5] Update tests --- sycl/test-e2e/Basic/fpga_tests/fpga_io_pipes.cpp | 12 +++++------- sycl/test-e2e/Graph/Explicit/host_task_last.cpp | 6 ++++-- sycl/test-e2e/Graph/RecordReplay/host_task_last.cpp | 6 ++++-- .../OptionalKernelFeatures/fp64-conv-emu.cpp | 2 +- sycl/test-e2e/Regression/isordered.cpp | 1 + sycl/test-e2e/SharedLib/use_with_dlopen.cpp | 6 +++--- .../SharedLib/use_with_dlopen_verify_cache.cpp | 6 +++--- .../no-unsupported-without-info.cpp | 3 +-- 8 files changed, 22 insertions(+), 20 deletions(-) diff --git a/sycl/test-e2e/Basic/fpga_tests/fpga_io_pipes.cpp b/sycl/test-e2e/Basic/fpga_tests/fpga_io_pipes.cpp index 6d2707fc01d82..1eb50966b76ee 100644 --- a/sycl/test-e2e/Basic/fpga_tests/fpga_io_pipes.cpp +++ b/sycl/test-e2e/Basic/fpga_tests/fpga_io_pipes.cpp @@ -1,10 +1,5 @@ -// The test is disabled, since no support added in FPGA backend yet. Check -// implementation correctness from CXX and SYCL languages perspective. -// UNSUPPORTED: true - -// REQUIRES: accelerator -// RUN: %{build} -o %t.out -// RUN: %{run} %t.out +// RUN: %{build} -fsyntax-only -o %t.out +// TODO: launch the test if the feature is supported. //==------------ fpga_io_pipes.cpp - SYCL FPGA pipes test ------------------==// // // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. @@ -19,6 +14,9 @@ #include "io_pipe_def.h" +// TODO: run is disabled, since no support added in FPGA backend yet. Check +// implementation correctness from CXX and SYCL languages perspective. + // This test is supposed to be run only on Intel FPGA emulator. Change it when // we have more experience with IO pipe feature in SYCL. // The emulator creates files (one for I pipe, another for O pipe) with the diff --git a/sycl/test-e2e/Graph/Explicit/host_task_last.cpp b/sycl/test-e2e/Graph/Explicit/host_task_last.cpp index 7dae93ab2c23f..a64475a6530ff 100644 --- a/sycl/test-e2e/Graph/Explicit/host_task_last.cpp +++ b/sycl/test-e2e/Graph/Explicit/host_task_last.cpp @@ -3,9 +3,11 @@ // Extra run to check for leaks in Level Zero using UR_L0_LEAKS_DEBUG // RUN: %if level_zero %{env SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=0 %{l0_leak_check} %{run} %t.out 2>&1 | FileCheck %s --implicit-check-not=LEAK %} +// clang-format off // Extra run to check for immediate-command-list in Level Zero -// RUNx: %if level_zero %{env SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=1 %{l0_leak_check} %{run} %t.out 2>&1 | FileCheck %s --implicit-check-not=LEAK %} -// RUNx-TRACKER: https://github.com/intel/llvm/issues/14473 +// TODO: enable the run-line below when the issue is fixed - https://github.com/intel/llvm/issues/14473 +// %if level_zero %{env SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=1 %{l0_leak_check} %{run} %t.out 2>&1 | FileCheck %s --implicit-check-not=LEAK %} +// clang-format on // REQUIRES: aspect-usm_shared_allocations diff --git a/sycl/test-e2e/Graph/RecordReplay/host_task_last.cpp b/sycl/test-e2e/Graph/RecordReplay/host_task_last.cpp index bf1817bc1c09f..28eee1491a264 100644 --- a/sycl/test-e2e/Graph/RecordReplay/host_task_last.cpp +++ b/sycl/test-e2e/Graph/RecordReplay/host_task_last.cpp @@ -3,9 +3,11 @@ // Extra run to check for leaks in Level Zero using UR_L0_LEAKS_DEBUG // RUN: %if level_zero %{env SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=0 %{l0_leak_check} %{run} %t.out 2>&1 | FileCheck %s --implicit-check-not=LEAK %} +// clang-format off // Extra run to check for immediate-command-list in Level Zero -// RUNx: %if level_zero %{env SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=1 %{l0_leak_check} %{run} %t.out 2>&1 | FileCheck %s --implicit-check-not=LEAK %} -// RUNx-TRACKER: https://github.com/intel/llvm/issues/14473 +// TODO: enable the run below when the issue is fixed - https://github.com/intel/llvm/issues/14473 +// %if level_zero %{env SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=1 %{l0_leak_check} %{run} %t.out 2>&1 | FileCheck %s --implicit-check-not=LEAK %} +// clang-format on // REQUIRES: aspect-usm_shared_allocations diff --git a/sycl/test-e2e/OptionalKernelFeatures/fp64-conv-emu.cpp b/sycl/test-e2e/OptionalKernelFeatures/fp64-conv-emu.cpp index 237a049c80f3d..81934fd4d2184 100644 --- a/sycl/test-e2e/OptionalKernelFeatures/fp64-conv-emu.cpp +++ b/sycl/test-e2e/OptionalKernelFeatures/fp64-conv-emu.cpp @@ -1,4 +1,4 @@ -// REQUIRES: ocloc, gpu, linux +// REQUIRES: ocloc, gpu, linux, aspect-fp64 // UNSUPPORTED: cuda, hip // RUN: %clangxx -fsycl -fsycl-targets=spir64_gen -Xsycl-target-backend "-device pvc" -fsycl-fp64-conv-emu -O0 %s -o %t_opt.out diff --git a/sycl/test-e2e/Regression/isordered.cpp b/sycl/test-e2e/Regression/isordered.cpp index 4b4d18b93896e..05ec9c0b73574 100644 --- a/sycl/test-e2e/Regression/isordered.cpp +++ b/sycl/test-e2e/Regression/isordered.cpp @@ -1,3 +1,4 @@ +// REQUIRES: aspect-fp64, aspect-fp16 // RUN: %{build} -o %t.out // RUN: %{run} %t.out diff --git a/sycl/test-e2e/SharedLib/use_with_dlopen.cpp b/sycl/test-e2e/SharedLib/use_with_dlopen.cpp index 460d056dbb0d2..22991e100b4eb 100644 --- a/sycl/test-e2e/SharedLib/use_with_dlopen.cpp +++ b/sycl/test-e2e/SharedLib/use_with_dlopen.cpp @@ -14,9 +14,9 @@ // RUN: %{run} %t3.out // This causes SEG. FAULT. -// RUNx: %{compile} -o %t4.out -DRUN_LAST -// RUNx: %{run} %t4.out -// RUNx-TRACKER: https://github.com/intel/llvm/issues/16031 +// Enable the lines below when the issue is fixed - https://github.com/intel/llvm/issues/16031 +// %{compile} -o %t4.out -DRUN_LAST +// %{run} %t4.out #include diff --git a/sycl/test-e2e/SharedLib/use_with_dlopen_verify_cache.cpp b/sycl/test-e2e/SharedLib/use_with_dlopen_verify_cache.cpp index d0df39df16dbe..ef90a0a3c9651 100644 --- a/sycl/test-e2e/SharedLib/use_with_dlopen_verify_cache.cpp +++ b/sycl/test-e2e/SharedLib/use_with_dlopen_verify_cache.cpp @@ -15,9 +15,9 @@ // clang-format off // This causes SEG. FAULT. -// RUNx: %{compile} -DRUN_LAST -// RUNx: env SYCL_UR_TRACE=2 %{run} %t.out 2>&1 | FileCheck %s --check-prefixes=CHECK-LAST,CHECK --implicit-check-not=piProgramBuild -// RUNx-TRACKER: https://github.com/intel/llvm/issues/16031 +// Enable the lines below when the issue is fixed - https://github.com/intel/llvm/issues/16031 +// %{compile} -DRUN_LAST +// env SYCL_UR_TRACE=2 %{run} %t.out 2>&1 | FileCheck %s --check-prefixes=CHECK-LAST,CHECK --implicit-check-not=piProgramBuild // clang-format on #include diff --git a/sycl/test/e2e_test_requirements/no-unsupported-without-info.cpp b/sycl/test/e2e_test_requirements/no-unsupported-without-info.cpp index 0d01b64415d89..3602d7d01ae95 100644 --- a/sycl/test/e2e_test_requirements/no-unsupported-without-info.cpp +++ b/sycl/test/e2e_test_requirements/no-unsupported-without-info.cpp @@ -54,7 +54,7 @@ // tests to match the required format and in that case you should just update // (i.e. reduce) the number and the list below. // -// NUMBER-OF-UNSUPPORTED-WITHOUT-INFO: 478 +// NUMBER-OF-UNSUPPORTED-WITHOUT-INFO: 477 // // List of improperly UNSUPPORTED tests. // Remove the CHECK once the test has been properly UNSUPPORTED. @@ -77,7 +77,6 @@ // CHECK-NEXT: Basic/buffer/subbuffer.cpp // CHECK-NEXT: Basic/build_log.cpp // CHECK-NEXT: Basic/code_location_e2e.cpp -// CHECK-NEXT: Basic/fpga_tests/fpga_io_pipes.cpp // CHECK-NEXT: Basic/free_function_queries/free_function_queries.cpp // CHECK-NEXT: Basic/free_function_queries/free_function_queries_sub_group.cpp // CHECK-NEXT: Basic/free_function_queries/free_function_queries_sub_group.cpp From 41e3ebd99d357a979859bdcb9ce2b8fb4a8a30b1 Mon Sep 17 00:00:00 2001 From: "Kornev, Nikita" Date: Mon, 11 Nov 2024 10:17:20 -0800 Subject: [PATCH 4/5] update the main test --- sycl/test-e2e/SharedLib/use_with_dlopen.cpp | 3 +- .../no-runx-without-tracker.cpp | 29 ++----------------- 2 files changed, 5 insertions(+), 27 deletions(-) diff --git a/sycl/test-e2e/SharedLib/use_with_dlopen.cpp b/sycl/test-e2e/SharedLib/use_with_dlopen.cpp index 22991e100b4eb..d042e8d711ebb 100644 --- a/sycl/test-e2e/SharedLib/use_with_dlopen.cpp +++ b/sycl/test-e2e/SharedLib/use_with_dlopen.cpp @@ -14,7 +14,8 @@ // RUN: %{run} %t3.out // This causes SEG. FAULT. -// Enable the lines below when the issue is fixed - https://github.com/intel/llvm/issues/16031 +// Enable the lines below when the issue is fixed: +// https://github.com/intel/llvm/issues/16031 // %{compile} -o %t4.out -DRUN_LAST // %{run} %t4.out diff --git a/sycl/test/e2e_test_requirements/no-runx-without-tracker.cpp b/sycl/test/e2e_test_requirements/no-runx-without-tracker.cpp index fcea2bfd87bfc..63522c1c86cc2 100644 --- a/sycl/test/e2e_test_requirements/no-runx-without-tracker.cpp +++ b/sycl/test/e2e_test_requirements/no-runx-without-tracker.cpp @@ -1,29 +1,6 @@ -// This test is intended to ensure that we have no tests marked as RUNx -// without a tracker information added to a test. If it fails - please create -// a tracker for RUNx-marked test. -// -// The format we check is: -// RUNx: command -// RUNx-TRACKER: [GitHub issue URL|Internal tracker ID] -// -// GitHub issue URL format: -// https://github.com/owner/repo/issues/12345 -// -// Internal tracker ID format: -// PROJECT-123456 +// This test is intended to ensure that we have no tests marked as RUNx. +// If it fails - please remove RUNx and provide a TODO with a tracker. // // REQUIRES: linux // -// Explanation of the command: -// - search for all "RUNx" occurrences, display line with match and the next one -// -I, --include to drop binary files and other unrelated files -// - in the result, search for "RUNx" again, but invert the result - this -// allows us to get the line *after* RUNx -// - in those lines, check that RUNx-TRACKER is present and correct. Once -// again, invert the search to get all "bad" lines; running it with "not" as -// grep exits with 1 if it finds nothing -// -// RUN: grep -rI "RUNx:" %S/../../test-e2e \ -// RUN: -A 1 --include=*.cpp --no-group-separator | \ -// RUN: grep -v "RUNx:" | \ -// RUN: not grep -Pv "RUNx-TRACKER:\s+(?:https://github.com/[\w\d-]+/[\w\d-]+/issues/[\d]+)|(?:[\w]+-[\d]+)" +// RUN: not grep -rI "RUNx:" %S/../../test-e2e From 54232144683124702e95f8026c11e9d90aaf8705 Mon Sep 17 00:00:00 2001 From: "Kornev, Nikita" Date: Mon, 11 Nov 2024 11:08:33 -0800 Subject: [PATCH 5/5] delete runx test --- sycl/test/e2e_test_requirements/no-runx-without-tracker.cpp | 6 ------ 1 file changed, 6 deletions(-) delete mode 100644 sycl/test/e2e_test_requirements/no-runx-without-tracker.cpp diff --git a/sycl/test/e2e_test_requirements/no-runx-without-tracker.cpp b/sycl/test/e2e_test_requirements/no-runx-without-tracker.cpp deleted file mode 100644 index 63522c1c86cc2..0000000000000 --- a/sycl/test/e2e_test_requirements/no-runx-without-tracker.cpp +++ /dev/null @@ -1,6 +0,0 @@ -// This test is intended to ensure that we have no tests marked as RUNx. -// If it fails - please remove RUNx and provide a TODO with a tracker. -// -// REQUIRES: linux -// -// RUN: not grep -rI "RUNx:" %S/../../test-e2e