[SYCL] Align is_compatible with compile_target checks #16060
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergey-semenov
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
uditagarwal97
approved these changes
Nov 12, 2024
Contributor
uditagarwal97
left a comment
uditagarwal97
left a comment
There was a problem hiding this comment.
LGTM. Can we please add a summary of this change in the PR description?
sergey-semenov
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
Contributor
Author
Done |
sergey-semenov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sergey-semenov
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
sergey-semenov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Contributor
Author
|
@uditagarwal97 Could you please have another look? I had to bring back the target check from the is_compatible path since the comment about the lack of property indicating a JIT compiled image was incorrect. This check wasn't there in the standard image selection path before, but it should just filter more incompatible images out earlier, before the urDeviceSelectBinary call. |
sergey-semenov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sergey-semenov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sergey-semenov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sergey-semenov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sergey-semenov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Contributor
Author
|
@uditagarwal97 Another small change, added handling of kernel fusion related JIT compilation targets for CUDA & HIP. |
uditagarwal97
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is_compatible used a different logic compared to the checks used in the standard image selection path. This change makes both use a single code path, which adds compile_target related checks to is_compatible.