[CI] Change CODEOWNERS of sycl/test-e2e/LLVMIntrinsicLowering/* to intel/dpcpp-spirv-reviewers
#16067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…intel/dpcpp-spirv-reviewers
AlexeySachkov
approved these changes
Nov 13, 2024
Contributor
AlexeySachkov
left a comment
AlexeySachkov
left a comment
There was a problem hiding this comment.
As I understand it, those tests were added to check a workaround which we have in place to avoid using certain SPIR-V extension, because it is not yet properly supported in all our target backends. From that point of view SPIR-V team does sound like a right owner of those.
I also hope that this workaround is a temporary thing, so that at some point we will simply drop that folder completely
sarnex
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the owners of sycl/test-e2e/LLVMIntrinsicLowering/* are SYCL RT reviewers but I see that all the test cases here related to llvm-spirv.
I propose changing the code owners of these tests to intel/dpcpp-spirv-reviewers instead.