From 3adb475178f1ba5ebad55c72fddfb7020bc6125a Mon Sep 17 00:00:00 2001 From: Steffen Larsen Date: Thu, 14 Nov 2024 13:51:28 +0100 Subject: [PATCH] Revert "[DeviceASAN] Enable e2e test "private_nullptr.cpp" (#15995)" This reverts commit c0015204bfd926e979ec37395af03a3daca35b39. --- .../AddressSanitizer/nullpointer/private_nullptr.cpp | 8 ++++++-- .../e2e_test_requirements/no-xfail-without-tracker.cpp | 5 +++-- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/sycl/test-e2e/AddressSanitizer/nullpointer/private_nullptr.cpp b/sycl/test-e2e/AddressSanitizer/nullpointer/private_nullptr.cpp index 4ac02b8d32343..6b013a2aee1e2 100644 --- a/sycl/test-e2e/AddressSanitizer/nullpointer/private_nullptr.cpp +++ b/sycl/test-e2e/AddressSanitizer/nullpointer/private_nullptr.cpp @@ -6,6 +6,9 @@ // RUN: %{build} %device_asan_flags -O2 -g -o %t3.out // RUN: %{run} not %t3.out 2>&1 | FileCheck %s +// FIXME: There's an issue in gfx driver, so this test pending here. +// XFAIL: * + #include #include @@ -19,14 +22,15 @@ int main() { sycl::nd_range<1>(N, 1), [=](sycl::nd_item<1> item) { auto private_array = sycl::ext::oneapi::experimental::static_address_cast< - sycl::access::address_space::private_space>(array); + sycl::access::address_space::private_space, + sycl::access::decorated::no>(array); private_array[0] = 0; }); Q.wait(); }); // CHECK: ERROR: DeviceSanitizer: null-pointer-access on Unknown Memory // CHECK: WRITE of size 4 at kernel {{<.*MyKernel>}} LID(0, 0, 0) GID({{.*}}, 0, 0) - // CHECK: {{.*private_nullptr.cpp}}:[[@LINE-6]] + // CHECK: {{.*private_nullptr.cpp}}:[[@LINE-5]] return 0; } diff --git a/sycl/test/e2e_test_requirements/no-xfail-without-tracker.cpp b/sycl/test/e2e_test_requirements/no-xfail-without-tracker.cpp index dbf8dac7112b3..7274f59992c72 100644 --- a/sycl/test/e2e_test_requirements/no-xfail-without-tracker.cpp +++ b/sycl/test/e2e_test_requirements/no-xfail-without-tracker.cpp @@ -51,12 +51,13 @@ // tests to match the required format and in that case you should just update // (i.e. reduce) the number and the list below. // -// NUMBER-OF-XFAIL-WITHOUT-TRACKER: 141 +// NUMBER-OF-XFAIL-WITHOUT-TRACKER: 142 // // List of improperly XFAIL-ed tests. // Remove the CHECK once the test has been properly XFAIL-ed. // -// CHECK: Basic/aspects.cpp +// CHECK: AddressSanitizer/nullpointer/private_nullptr.cpp +// CHECK-NEXT: Basic/aspects.cpp // CHECK-NEXT: Basic/buffer/reinterpret.cpp // CHECK-NEXT: Basic/device_event.cpp // CHECK-NEXT: Basic/diagnostics/handler.cpp