[SYCL][RTC] Ensure template kernel instantiation #16138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julian Oppermann <julian.oppermann@codeplay.com>
jopperm
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
jopperm
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sommerlukas
reviewed
Nov 21, 2024
Contributor
sommerlukas
left a comment
sommerlukas
left a comment
There was a problem hiding this comment.
One minor style nit.
Signed-off-by: Julian Oppermann <julian.oppermann@codeplay.com>
jopperm
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
jopperm
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sommerlukas
approved these changes
Nov 21, 2024
cperkinsintel
approved these changes
Nov 25, 2024
Signed-off-by: Julian Oppermann <julian.oppermann@codeplay.com>
jopperm
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
jopperm
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Contributor
Author
|
@intel/llvm-gatekeepers Please merge. The failing E2E seems unrelated to this change, and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a step towards feature parity between the
syclandsycl_jitRTC implementations, this PR cherry-picks @cperkinsintel's workaround from #16305 for triggering explicit template instantiations.