From 369ccf057431fa934cc643226e98243c1a6ca45f Mon Sep 17 00:00:00 2001 From: Lukas Sommer Date: Tue, 3 Dec 2024 08:32:07 +0000 Subject: [PATCH 1/2] [SYCL][RTC] Fix warning caused by default case Fix warning resulting from default case covering other cases, causing post-commit to fail. Signed-off-by: Lukas Sommer --- sycl-jit/jit-compiler/lib/rtc/DeviceCompilation.cpp | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/sycl-jit/jit-compiler/lib/rtc/DeviceCompilation.cpp b/sycl-jit/jit-compiler/lib/rtc/DeviceCompilation.cpp index b41e07082701b..0f12c5cb1d801 100644 --- a/sycl-jit/jit-compiler/lib/rtc/DeviceCompilation.cpp +++ b/sycl-jit/jit-compiler/lib/rtc/DeviceCompilation.cpp @@ -205,12 +205,8 @@ class LLVMDiagnosticWrapper : public llvm::DiagnosticHandler { return "ERROR"; case llvm::DiagnosticSeverity::DS_Warning: return "WARNING"; - case llvm::DiagnosticSeverity::DS_Note: - return "NOTE:"; - case llvm::DiagnosticSeverity::DS_Remark: - return "REMARK:"; default: - llvm_unreachable("Unhandled case"); + return "NOTE:"; } }(DI.getSeverity()); LogPrinter << Prefix; From 9038a46418c7cdeb5434c4187ccb8d1503a631f7 Mon Sep 17 00:00:00 2001 From: Lukas Sommer Date: Tue, 3 Dec 2024 08:39:31 +0000 Subject: [PATCH 2/2] Fix message format Signed-off-by: Lukas Sommer --- sycl-jit/jit-compiler/lib/rtc/DeviceCompilation.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sycl-jit/jit-compiler/lib/rtc/DeviceCompilation.cpp b/sycl-jit/jit-compiler/lib/rtc/DeviceCompilation.cpp index 0f12c5cb1d801..876c4e431d700 100644 --- a/sycl-jit/jit-compiler/lib/rtc/DeviceCompilation.cpp +++ b/sycl-jit/jit-compiler/lib/rtc/DeviceCompilation.cpp @@ -202,9 +202,9 @@ class LLVMDiagnosticWrapper : public llvm::DiagnosticHandler { auto Prefix = [](DiagnosticSeverity Severity) -> llvm::StringLiteral { switch (Severity) { case llvm::DiagnosticSeverity::DS_Error: - return "ERROR"; + return "ERROR:"; case llvm::DiagnosticSeverity::DS_Warning: - return "WARNING"; + return "WARNING:"; default: return "NOTE:"; }