From 39cdd1aa625eee3a7f55ce3fe96cc6148b73f21a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=C3=A9sz=C3=A1ros=20Gergely?= Date: Wed, 11 Dec 2024 17:21:12 +0100 Subject: [PATCH] [SYCL][libdevice][CMake][Trivial] Fix imf-fallback missing in NVPTX Seems like the IMF fallback libraries are not collected in the merged libdevice for NVPTX and AMDGPU, because the name of the CMake property was wrong. I don't know why our testing does not catch this. I have seen this result in unresolved symbols earlier, but I have been sitting on this patch for a while and did not try with current trunk. --- libdevice/cmake/modules/SYCLLibdevice.cmake | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libdevice/cmake/modules/SYCLLibdevice.cmake b/libdevice/cmake/modules/SYCLLibdevice.cmake index 0b2c1780a4756..d2afc546d69d9 100644 --- a/libdevice/cmake/modules/SYCLLibdevice.cmake +++ b/libdevice/cmake/modules/SYCLLibdevice.cmake @@ -584,7 +584,7 @@ foreach(arch IN LISTS devicelib_arch) append_to_property( ${bc_binary_dir}/libsycl-fallback-imf-${arch}-${dtype}.${bc-suffix} - PROPERTY_NAME ${arch}) + PROPERTY_NAME BC_DEVICE_LIBS_${arch}) endforeach() endforeach()