-
Notifications
You must be signed in to change notification settings - Fork 794
[Driver][SYCL] Support 64bit long double for SYCL GPU compilation #16441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Fixes: #15852 |
70b83f9 to
689f9ac
Compare
|
Looks like linux gen12 is experiencing some problems. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For all of these, I believe the expected option syntax is to use --target=x86_64-unknown-linux-gnu -fsycl-targets=nvptx64-nvidia-cuda. Use of --target=<triple> is preferred over -target <triple> moving forward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. I've only updated tests that I've added in this patch.
As a side note, it seems strange that sycl target triple option gets only one hyphen, both seem to be following the same pattern of:
hyphen[hyphen]target_name=triple
but end up spelled out differently:
--target=<triple>
vs:
-fsycl-targets=<triple>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use of --target=<triple> is a general option. There are some similar options for offloading that use the double hyphen syntax which are also general in nature for offloading. Consider -fsycl-targets=<target> to be in a similar usage family as -fopenmp-targets=<target>. Moving forward when looking at the new offloading model approach, use of --offload-arch=<arch> would be used to target other devices which better fits within the double hyphen syntax.
689f9ac to
4388fec
Compare
mdtoguchi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
f29e426 to
83260bb
Compare
|
@intel/llvm-gatekeepers this should be ready to roll. Thank you. |
|
The post-commit failure is unrelated to changes in this PR, the failure is already tracked in #8803. |
Make sure that
-mlong-double-64option is supported on HIP/Cuda.