From 30fd861cb7e83d77f3010b330058ce97d3067d7c Mon Sep 17 00:00:00 2001 From: Xavier Hallade Date: Thu, 10 Apr 2025 14:21:45 +0200 Subject: [PATCH] [SYCL] Require building with zstd library SYCL device image compression requires zstd. Running `clang++ -fsycl --offload-compress` with a version of the compiler compiled without zstd leads to an error. Instead of complicating the handling of device image compression to also make it optional, it's cleaner to avoid compiling without zstd library, and to make it a required dependency for SYCL. Using LLVM_ENABLE_ZSTD=FORCE_ON prevents from compiling without zstd. --- buildbot/configure.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/buildbot/configure.py b/buildbot/configure.py index d0fb2c29dcddf..ba02491ef01cb 100644 --- a/buildbot/configure.py +++ b/buildbot/configure.py @@ -64,7 +64,6 @@ def do_configure(args, passthrough_args): sycl_enable_xpti_tracing = "ON" xpti_enable_werror = "OFF" - llvm_enable_zstd = "ON" spirv_enable_dis = "OFF" if sys.platform != "darwin": @@ -188,7 +187,7 @@ def do_configure(args, passthrough_args): "-DLLVM_ENABLE_PROJECTS={}".format(llvm_enable_projects), "-DSYCL_BUILD_PI_HIP_PLATFORM={}".format(sycl_build_pi_hip_platform), "-DLLVM_BUILD_TOOLS=ON", - "-DLLVM_ENABLE_ZSTD={}".format(llvm_enable_zstd), + "-DLLVM_ENABLE_ZSTD=FORCE_ON", # Required by SYCL device image compression. "-DLLVM_USE_STATIC_ZSTD=ON", "-DSYCL_ENABLE_WERROR={}".format(sycl_werror), "-DCMAKE_INSTALL_PREFIX={}".format(install_dir),