From df8990c209e9853165e490551ab886a096c95cb1 Mon Sep 17 00:00:00 2001 From: Ian Li Date: Fri, 3 Oct 2025 12:33:57 -0700 Subject: [PATCH 01/22] test pushing to branch --- devops/actions/run-tests/benchmark/action.yml | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/devops/actions/run-tests/benchmark/action.yml b/devops/actions/run-tests/benchmark/action.yml index e09582be0fde6..a69ed75acb8b4 100644 --- a/devops/actions/run-tests/benchmark/action.yml +++ b/devops/actions/run-tests/benchmark/action.yml @@ -134,9 +134,10 @@ runs: cd - - name: Checkout results repo - shell: bash - run: | - git clone -b unify-ci https://github.com/intel/llvm-ci-perf-results + uses: actions/checkout@v5 + with: + ref: ianayl/benchmark-ci-results-test + path: llvm-ci-perf-results - name: Run compute-benchmarks env: # Need to append "__" to save name in order to follow @@ -237,9 +238,9 @@ runs: shell: bash run: | cd "./llvm-ci-perf-results" - git config user.name "SYCL Benchmarking Bot" - git config user.email "sys_sycl_benchmarks@intel.com" - results_branch="unify-ci" + git config user.name "github-actions[bot]" + git config user.email "github-actions[bot]@users.noreply.github.com" + # results_branch="ianayl/benchmark-ci-results-test" if git diff --quiet && git diff --cached --quiet; then echo "No new results added, skipping push." @@ -252,7 +253,7 @@ runs: git commit -m "[GHA] Upload compute-benchmarks results from https://github.com/intel/llvm/actions/runs/${{ github.run_id }}" results_file="$(git diff HEAD~1 --name-only -- results/ | head -n 1)" - if git push "https://$GITHUB_TOKEN@github.com/intel/llvm-ci-perf-results.git" "$results_branch"; then + if git push; then echo "Push succeeded" break fi From 7ce4420d257bf81b1102dbab65d5e8a147c42363 Mon Sep 17 00:00:00 2001 From: Ian Li Date: Wed, 8 Oct 2025 10:22:37 -0700 Subject: [PATCH 02/22] give write permissions --- .github/workflows/sycl-linux-run-tests.yml | 4 +++- .github/workflows/sycl-ur-perf-benchmarking.yml | 2 ++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/sycl-linux-run-tests.yml b/.github/workflows/sycl-linux-run-tests.yml index de81af128d58d..2867a288e9a87 100644 --- a/.github/workflows/sycl-linux-run-tests.yml +++ b/.github/workflows/sycl-linux-run-tests.yml @@ -220,6 +220,8 @@ jobs: if: github.event_name == 'workflow_dispatch' || inputs.skip_run == 'false' name: ${{ inputs.name }} runs-on: ${{ fromJSON(inputs.runner) }} + permissions: + contents: write # Needed for benchmarking job to push results container: image: ${{ inputs.image || 'ghcr.io/intel/llvm/ubuntu2404_intel_drivers:alldeps'}} options: ${{ inputs.image_options }} @@ -361,4 +363,4 @@ jobs: build_ref: ${{ inputs.repo_ref }} env: RUNNER_TAG: ${{ inputs.runner }} - GITHUB_TOKEN: ${{ secrets.LLVM_SYCL_BENCHMARK_TOKEN }} + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} diff --git a/.github/workflows/sycl-ur-perf-benchmarking.yml b/.github/workflows/sycl-ur-perf-benchmarking.yml index b5b14cf34ade1..14af4ee7d1b93 100644 --- a/.github/workflows/sycl-ur-perf-benchmarking.yml +++ b/.github/workflows/sycl-ur-perf-benchmarking.yml @@ -174,6 +174,8 @@ jobs: run_benchmarks_build: name: Run Benchmarks on Build needs: [ build_sycl, sanitize_inputs ] + permissions: + contents: write strategy: matrix: include: From 866b64ebd631c5aafb87dd7aa82a0c9980237ccd Mon Sep 17 00:00:00 2001 From: Ian Li Date: Wed, 8 Oct 2025 10:45:33 -0700 Subject: [PATCH 03/22] amend perms --- .github/workflows/sycl-ur-perf-benchmarking.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/sycl-ur-perf-benchmarking.yml b/.github/workflows/sycl-ur-perf-benchmarking.yml index 14af4ee7d1b93..0f73ee7db21ee 100644 --- a/.github/workflows/sycl-ur-perf-benchmarking.yml +++ b/.github/workflows/sycl-ur-perf-benchmarking.yml @@ -176,6 +176,7 @@ jobs: needs: [ build_sycl, sanitize_inputs ] permissions: contents: write + packages: read strategy: matrix: include: From b518e18e49ca43769e43f47e4789c49b71b9551f Mon Sep 17 00:00:00 2001 From: Ian Li Date: Wed, 8 Oct 2025 13:23:55 -0700 Subject: [PATCH 04/22] Revert "amend perms" This reverts commit 866b64ebd631c5aafb87dd7aa82a0c9980237ccd. --- .github/workflows/sycl-ur-perf-benchmarking.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/sycl-ur-perf-benchmarking.yml b/.github/workflows/sycl-ur-perf-benchmarking.yml index 0f73ee7db21ee..14af4ee7d1b93 100644 --- a/.github/workflows/sycl-ur-perf-benchmarking.yml +++ b/.github/workflows/sycl-ur-perf-benchmarking.yml @@ -176,7 +176,6 @@ jobs: needs: [ build_sycl, sanitize_inputs ] permissions: contents: write - packages: read strategy: matrix: include: From 2109b73608e3178f199efae473fe35f366d93167 Mon Sep 17 00:00:00 2001 From: Ian Li Date: Wed, 8 Oct 2025 13:23:56 -0700 Subject: [PATCH 05/22] Revert "give write permissions" This reverts commit 7ce4420d257bf81b1102dbab65d5e8a147c42363. --- .github/workflows/sycl-linux-run-tests.yml | 4 +--- .github/workflows/sycl-ur-perf-benchmarking.yml | 2 -- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/.github/workflows/sycl-linux-run-tests.yml b/.github/workflows/sycl-linux-run-tests.yml index 2867a288e9a87..de81af128d58d 100644 --- a/.github/workflows/sycl-linux-run-tests.yml +++ b/.github/workflows/sycl-linux-run-tests.yml @@ -220,8 +220,6 @@ jobs: if: github.event_name == 'workflow_dispatch' || inputs.skip_run == 'false' name: ${{ inputs.name }} runs-on: ${{ fromJSON(inputs.runner) }} - permissions: - contents: write # Needed for benchmarking job to push results container: image: ${{ inputs.image || 'ghcr.io/intel/llvm/ubuntu2404_intel_drivers:alldeps'}} options: ${{ inputs.image_options }} @@ -363,4 +361,4 @@ jobs: build_ref: ${{ inputs.repo_ref }} env: RUNNER_TAG: ${{ inputs.runner }} - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + GITHUB_TOKEN: ${{ secrets.LLVM_SYCL_BENCHMARK_TOKEN }} diff --git a/.github/workflows/sycl-ur-perf-benchmarking.yml b/.github/workflows/sycl-ur-perf-benchmarking.yml index 14af4ee7d1b93..b5b14cf34ade1 100644 --- a/.github/workflows/sycl-ur-perf-benchmarking.yml +++ b/.github/workflows/sycl-ur-perf-benchmarking.yml @@ -174,8 +174,6 @@ jobs: run_benchmarks_build: name: Run Benchmarks on Build needs: [ build_sycl, sanitize_inputs ] - permissions: - contents: write strategy: matrix: include: From 6e73cf7ff0270b3ddb446c0227d14ce03cbd88a0 Mon Sep 17 00:00:00 2001 From: Ian Li Date: Wed, 8 Oct 2025 13:56:40 -0700 Subject: [PATCH 06/22] test perms --- .github/workflows/sycl-ur-perf-benchmarking.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/sycl-ur-perf-benchmarking.yml b/.github/workflows/sycl-ur-perf-benchmarking.yml index b5b14cf34ade1..02ed3dcb0fcf1 100644 --- a/.github/workflows/sycl-ur-perf-benchmarking.yml +++ b/.github/workflows/sycl-ur-perf-benchmarking.yml @@ -174,6 +174,9 @@ jobs: run_benchmarks_build: name: Run Benchmarks on Build needs: [ build_sycl, sanitize_inputs ] + permissions: + content: write + packages: read strategy: matrix: include: From e20975f7b7d025ccab7533642ae6c718a2d09d05 Mon Sep 17 00:00:00 2001 From: Ian Li Date: Wed, 8 Oct 2025 13:58:50 -0700 Subject: [PATCH 07/22] typo --- .github/workflows/sycl-ur-perf-benchmarking.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/sycl-ur-perf-benchmarking.yml b/.github/workflows/sycl-ur-perf-benchmarking.yml index 02ed3dcb0fcf1..0f73ee7db21ee 100644 --- a/.github/workflows/sycl-ur-perf-benchmarking.yml +++ b/.github/workflows/sycl-ur-perf-benchmarking.yml @@ -175,7 +175,7 @@ jobs: name: Run Benchmarks on Build needs: [ build_sycl, sanitize_inputs ] permissions: - content: write + contents: write packages: read strategy: matrix: From 3bea8056eccd9109e32f61d4f8ab5f9b0902eeb5 Mon Sep 17 00:00:00 2001 From: Ian Li Date: Wed, 8 Oct 2025 15:08:04 -0700 Subject: [PATCH 08/22] more perms --- .github/workflows/sycl-linux-run-tests.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/sycl-linux-run-tests.yml b/.github/workflows/sycl-linux-run-tests.yml index de81af128d58d..24224b6489d06 100644 --- a/.github/workflows/sycl-linux-run-tests.yml +++ b/.github/workflows/sycl-linux-run-tests.yml @@ -212,7 +212,7 @@ on: - "run-only" permissions: - contents: read + contents: write packages: read jobs: @@ -361,4 +361,4 @@ jobs: build_ref: ${{ inputs.repo_ref }} env: RUNNER_TAG: ${{ inputs.runner }} - GITHUB_TOKEN: ${{ secrets.LLVM_SYCL_BENCHMARK_TOKEN }} + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} From 418bd1d119954486ab3b5fe7c62aba03f5c7576e Mon Sep 17 00:00:00 2001 From: Ian Li Date: Thu, 9 Oct 2025 09:58:26 -0700 Subject: [PATCH 09/22] test fail --- devops/actions/run-tests/benchmark/action.yml | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/devops/actions/run-tests/benchmark/action.yml b/devops/actions/run-tests/benchmark/action.yml index a69ed75acb8b4..748f23702c2b0 100644 --- a/devops/actions/run-tests/benchmark/action.yml +++ b/devops/actions/run-tests/benchmark/action.yml @@ -240,7 +240,6 @@ runs: cd "./llvm-ci-perf-results" git config user.name "github-actions[bot]" git config user.email "github-actions[bot]@users.noreply.github.com" - # results_branch="ianayl/benchmark-ci-results-test" if git diff --quiet && git diff --cached --quiet; then echo "No new results added, skipping push." @@ -253,18 +252,18 @@ runs: git commit -m "[GHA] Upload compute-benchmarks results from https://github.com/intel/llvm/actions/runs/${{ github.run_id }}" results_file="$(git diff HEAD~1 --name-only -- results/ | head -n 1)" - if git push; then - echo "Push succeeded" - break - fi + # if git push; then + # echo "Push succeeded" + # break + # fi echo "Push failed, retrying..." if [ -n "$results_file" ]; then cached_result="$(mktemp -d)/$(basename $results_file)" mv "$results_file" "$cached_result" - git reset --hard "origin/$results_branch" - git pull origin "$results_branch" + git reset --hard "origin/ianayl/benchmark-ci-results-test" + git pull mv "$cached_result" "$results_file" fi From 1539867757a04f2843bddfd2047ea28a2a1ccf44 Mon Sep 17 00:00:00 2001 From: Ian Li Date: Thu, 9 Oct 2025 12:22:13 -0700 Subject: [PATCH 10/22] set to correct repo --- .github/workflows/sycl-docs.yml | 2 +- devops/actions/run-tests/benchmark/action.yml | 12 ++++++------ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/workflows/sycl-docs.yml b/.github/workflows/sycl-docs.yml index c442fe37e42da..445a224a0de1e 100644 --- a/.github/workflows/sycl-docs.yml +++ b/.github/workflows/sycl-docs.yml @@ -64,7 +64,7 @@ jobs: touch .nojekyll # Update benchmarking dashboard configuration cat << EOF > benchmarks/config.js - remoteDataUrl = 'https://raw.githubusercontent.com/intel/llvm-ci-perf-results/refs/heads/unify-ci/'; + remoteDataUrl = 'https://raw.githubusercontent.com/intel/llvm/refs/heads/benchmark-ci-results/'; defaultCompareNames = ["Baseline_PVC_L0"]; EOF # Upload the generated docs as an artifact and deploy to GitHub Pages. diff --git a/devops/actions/run-tests/benchmark/action.yml b/devops/actions/run-tests/benchmark/action.yml index 748f23702c2b0..56ffa879119bb 100644 --- a/devops/actions/run-tests/benchmark/action.yml +++ b/devops/actions/run-tests/benchmark/action.yml @@ -136,7 +136,7 @@ runs: - name: Checkout results repo uses: actions/checkout@v5 with: - ref: ianayl/benchmark-ci-results-test + ref: benchmark-ci-results path: llvm-ci-perf-results - name: Run compute-benchmarks env: @@ -252,17 +252,17 @@ runs: git commit -m "[GHA] Upload compute-benchmarks results from https://github.com/intel/llvm/actions/runs/${{ github.run_id }}" results_file="$(git diff HEAD~1 --name-only -- results/ | head -n 1)" - # if git push; then - # echo "Push succeeded" - # break - # fi + if git push; then + echo "Push succeeded" + break + fi echo "Push failed, retrying..." if [ -n "$results_file" ]; then cached_result="$(mktemp -d)/$(basename $results_file)" mv "$results_file" "$cached_result" - git reset --hard "origin/ianayl/benchmark-ci-results-test" + git reset --hard "origin/benchmark-ci-results" git pull mv "$cached_result" "$results_file" From 8e1f1b8541a30de9d05e72942d21fb119a7c8963 Mon Sep 17 00:00:00 2001 From: Ian Li Date: Thu, 9 Oct 2025 16:51:07 -0700 Subject: [PATCH 11/22] switch branch --- .github/workflows/sycl-docs.yml | 2 +- devops/actions/run-tests/benchmark/action.yml | 7 +++++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/.github/workflows/sycl-docs.yml b/.github/workflows/sycl-docs.yml index 445a224a0de1e..fa11280b817b9 100644 --- a/.github/workflows/sycl-docs.yml +++ b/.github/workflows/sycl-docs.yml @@ -64,7 +64,7 @@ jobs: touch .nojekyll # Update benchmarking dashboard configuration cat << EOF > benchmarks/config.js - remoteDataUrl = 'https://raw.githubusercontent.com/intel/llvm/refs/heads/benchmark-ci-results/'; + remoteDataUrl = 'https://raw.githubusercontent.com/intel/llvm/refs/heads/sycl-benchmark-ci-results/'; defaultCompareNames = ["Baseline_PVC_L0"]; EOF # Upload the generated docs as an artifact and deploy to GitHub Pages. diff --git a/devops/actions/run-tests/benchmark/action.yml b/devops/actions/run-tests/benchmark/action.yml index 56ffa879119bb..5ac311fbde950 100644 --- a/devops/actions/run-tests/benchmark/action.yml +++ b/devops/actions/run-tests/benchmark/action.yml @@ -75,6 +75,9 @@ runs: python3 ./devops/scripts/benchmarks/presets.py query "$PRESET" [ "$?" -ne 0 ] && exit 1 # Stop workflow if invalid preset echo "PRESET=$PRESET" >> $GITHUB_ENV + + # Set branch containing benchmark CI results: + echo "BENCHMARK_RESULTS_BRANCH=sycl-benchmark-ci-results" >> $GITHUB_ENV - name: Compute CPU core range to run benchmarks on shell: bash run: | @@ -136,7 +139,7 @@ runs: - name: Checkout results repo uses: actions/checkout@v5 with: - ref: benchmark-ci-results + ref: ${{ env.BENCHMARK_RESULTS_BRANCH }} path: llvm-ci-perf-results - name: Run compute-benchmarks env: @@ -262,7 +265,7 @@ runs: cached_result="$(mktemp -d)/$(basename $results_file)" mv "$results_file" "$cached_result" - git reset --hard "origin/benchmark-ci-results" + git reset --hard "origin/$BENCHMARK_CI_RESULTS" git pull mv "$cached_result" "$results_file" From 66c4b5c8f0c2358a8d3c8c484c8f1a3b16748f5b Mon Sep 17 00:00:00 2001 From: Ian Li Date: Fri, 10 Oct 2025 13:40:27 -0700 Subject: [PATCH 12/22] try removing manually passing secrets --- .github/workflows/sycl-linux-run-tests.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/sycl-linux-run-tests.yml b/.github/workflows/sycl-linux-run-tests.yml index 24224b6489d06..3ab62b981855b 100644 --- a/.github/workflows/sycl-linux-run-tests.yml +++ b/.github/workflows/sycl-linux-run-tests.yml @@ -361,4 +361,3 @@ jobs: build_ref: ${{ inputs.repo_ref }} env: RUNNER_TAG: ${{ inputs.runner }} - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} From baf64efdbdc45932591b28a0d2096c714fc411cb Mon Sep 17 00:00:00 2001 From: Ian Li Date: Tue, 14 Oct 2025 09:03:18 -0700 Subject: [PATCH 13/22] fix typo --- devops/actions/run-tests/benchmark/action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/devops/actions/run-tests/benchmark/action.yml b/devops/actions/run-tests/benchmark/action.yml index 5ac311fbde950..72c60ff5a8941 100644 --- a/devops/actions/run-tests/benchmark/action.yml +++ b/devops/actions/run-tests/benchmark/action.yml @@ -265,7 +265,7 @@ runs: cached_result="$(mktemp -d)/$(basename $results_file)" mv "$results_file" "$cached_result" - git reset --hard "origin/$BENCHMARK_CI_RESULTS" + git reset --hard "origin/$BENCHMARK_RESULTS_BRANCH" git pull mv "$cached_result" "$results_file" From ac56a43a92d252aaedad4df9adf5df518ee5b0de Mon Sep 17 00:00:00 2001 From: Ian Li Date: Tue, 14 Oct 2025 09:07:11 -0700 Subject: [PATCH 14/22] make write permissions job-level --- .github/workflows/sycl-linux-run-tests.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/sycl-linux-run-tests.yml b/.github/workflows/sycl-linux-run-tests.yml index 3ab62b981855b..2cbafb4737c9e 100644 --- a/.github/workflows/sycl-linux-run-tests.yml +++ b/.github/workflows/sycl-linux-run-tests.yml @@ -212,7 +212,7 @@ on: - "run-only" permissions: - contents: write + contents: read packages: read jobs: @@ -220,6 +220,9 @@ jobs: if: github.event_name == 'workflow_dispatch' || inputs.skip_run == 'false' name: ${{ inputs.name }} runs-on: ${{ fromJSON(inputs.runner) }} + permissions: + contents: write + packages: read container: image: ${{ inputs.image || 'ghcr.io/intel/llvm/ubuntu2404_intel_drivers:alldeps'}} options: ${{ inputs.image_options }} From a589c14369c1399e99b0b4081e9d9028f533735d Mon Sep 17 00:00:00 2001 From: Ian Li Date: Thu, 30 Oct 2025 15:48:08 -0700 Subject: [PATCH 15/22] fix perms --- .github/workflows/sycl-ur-perf-benchmarking.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/sycl-ur-perf-benchmarking.yml b/.github/workflows/sycl-ur-perf-benchmarking.yml index 0cc4894bcb0f3..2f70b5114a5b2 100644 --- a/.github/workflows/sycl-ur-perf-benchmarking.yml +++ b/.github/workflows/sycl-ur-perf-benchmarking.yml @@ -150,6 +150,9 @@ jobs: benchmark_dispatch: name: '[Dispatch] Benchmarks' needs: [ build_sycl_dispatch, sanitize_inputs_dispatch ] + permissions: + contents: write + packages: read if: always() && !cancelled() && needs.build_sycl_dispatch.outputs.build_conclusion == 'success' strategy: matrix: From 3ffa758629e3c9834921547a1e2bbcdc8bd857ca Mon Sep 17 00:00:00 2001 From: Ian Li Date: Thu, 30 Oct 2025 21:32:00 -0700 Subject: [PATCH 16/22] fix perms 2 --- .github/workflows/sycl-ur-perf-benchmarking.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/sycl-ur-perf-benchmarking.yml b/.github/workflows/sycl-ur-perf-benchmarking.yml index 2f70b5114a5b2..769db47963824 100644 --- a/.github/workflows/sycl-ur-perf-benchmarking.yml +++ b/.github/workflows/sycl-ur-perf-benchmarking.yml @@ -196,6 +196,9 @@ jobs: benchmark_nightly: name: '[Nightly] Benchmarks' needs: [build_nightly] + permissions: + contents: write + packages: read if: always() && !cancelled() && needs.build_nightly.outputs.build_conclusion == 'success' strategy: fail-fast: false From 9b92cfdd2d91722de7f8f7e66f6e1e09895d48af Mon Sep 17 00:00:00 2001 From: Ian Li Date: Thu, 30 Oct 2025 21:33:40 -0700 Subject: [PATCH 17/22] bump --- .github/workflows/sycl-ur-perf-benchmarking.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/sycl-ur-perf-benchmarking.yml b/.github/workflows/sycl-ur-perf-benchmarking.yml index 769db47963824..4890c1c26a7d1 100644 --- a/.github/workflows/sycl-ur-perf-benchmarking.yml +++ b/.github/workflows/sycl-ur-perf-benchmarking.yml @@ -247,6 +247,9 @@ jobs: test_benchmark_framework: name: '[PR] Benchmark suite testing' needs: [build_pr] + permissions: + contents: write + packages: read if: always() && !cancelled() && needs.build_pr.outputs.build_conclusion == 'success' uses: ./.github/workflows/sycl-linux-run-tests.yml with: From 25976a1a0555f668af292d483d8b7e7fb6ae81b3 Mon Sep 17 00:00:00 2001 From: Ian Li Date: Thu, 30 Oct 2025 21:46:07 -0700 Subject: [PATCH 18/22] shuffle perms for sycl-linux-run-tests --- .github/workflows/sycl-linux-run-tests.yml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/sycl-linux-run-tests.yml b/.github/workflows/sycl-linux-run-tests.yml index 34f451265d42b..533201081fc1a 100644 --- a/.github/workflows/sycl-linux-run-tests.yml +++ b/.github/workflows/sycl-linux-run-tests.yml @@ -233,9 +233,6 @@ jobs: if: github.event_name == 'workflow_dispatch' || inputs.skip_run == 'false' name: ${{ inputs.name }} runs-on: ${{ fromJSON(inputs.runner) }} - permissions: - contents: write - packages: read container: image: ${{ inputs.image || 'ghcr.io/intel/llvm/ubuntu2404_intel_drivers:alldeps'}} options: ${{ inputs.image_options }} @@ -367,6 +364,8 @@ jobs: - name: Run benchmarks if: inputs.tests_selector == 'benchmarks' + permissions: + contents: write uses: ./devops/actions/run-tests/benchmark with: target_devices: ${{ inputs.target_devices }} From 06697711c504d4f088f64dc307faab89373d7f97 Mon Sep 17 00:00:00 2001 From: Ian Li Date: Thu, 30 Oct 2025 22:01:57 -0700 Subject: [PATCH 19/22] permisisons changed, need to update --- .github/workflows/sycl-linux-precommit-aws.yml | 3 +++ .github/workflows/sycl-linux-precommit.yml | 4 ++++ .github/workflows/sycl-linux-run-tests.yml | 4 ++-- .github/workflows/sycl-nightly.yml | 10 ++++++++++ .github/workflows/sycl-post-commit.yml | 2 ++ .github/workflows/sycl-weekly.yml | 4 ++++ 6 files changed, 25 insertions(+), 2 deletions(-) diff --git a/.github/workflows/sycl-linux-precommit-aws.yml b/.github/workflows/sycl-linux-precommit-aws.yml index d11f2171bffaa..0dcca650acbf0 100644 --- a/.github/workflows/sycl-linux-precommit-aws.yml +++ b/.github/workflows/sycl-linux-precommit-aws.yml @@ -63,6 +63,9 @@ jobs: e2e-cuda: needs: [aws-start] uses: ./.github/workflows/sycl-linux-run-tests.yml + permissions: + contents: write + packages: read with: name: CUDA E2E runner: '["aws_cuda-${{ github.event.workflow_run.id }}-${{ github.event.workflow_run.run_attempt }}"]' diff --git a/.github/workflows/sycl-linux-precommit.yml b/.github/workflows/sycl-linux-precommit.yml index eae8323f95449..51b00a01ff379 100644 --- a/.github/workflows/sycl-linux-precommit.yml +++ b/.github/workflows/sycl-linux-precommit.yml @@ -144,6 +144,8 @@ jobs: E2E: needs: [build, detect_changes, compat_read_exclude] if: ${{ always() && !cancelled() && needs.build.outputs.build_conclusion == 'success' }} + permissions: + contents: write strategy: fail-fast: false matrix: @@ -231,6 +233,8 @@ jobs: test-perf: needs: [build, detect_changes] + permissions: + contents: write if: | always() && !cancelled() && needs.build.outputs.build_conclusion == 'success' diff --git a/.github/workflows/sycl-linux-run-tests.yml b/.github/workflows/sycl-linux-run-tests.yml index 533201081fc1a..2cca8802fae3f 100644 --- a/.github/workflows/sycl-linux-run-tests.yml +++ b/.github/workflows/sycl-linux-run-tests.yml @@ -233,6 +233,8 @@ jobs: if: github.event_name == 'workflow_dispatch' || inputs.skip_run == 'false' name: ${{ inputs.name }} runs-on: ${{ fromJSON(inputs.runner) }} + permissions: + contents: write container: image: ${{ inputs.image || 'ghcr.io/intel/llvm/ubuntu2404_intel_drivers:alldeps'}} options: ${{ inputs.image_options }} @@ -364,8 +366,6 @@ jobs: - name: Run benchmarks if: inputs.tests_selector == 'benchmarks' - permissions: - contents: write uses: ./devops/actions/run-tests/benchmark with: target_devices: ${{ inputs.target_devices }} diff --git a/.github/workflows/sycl-nightly.yml b/.github/workflows/sycl-nightly.yml index 7647533a8c68c..4ba42e293938f 100644 --- a/.github/workflows/sycl-nightly.yml +++ b/.github/workflows/sycl-nightly.yml @@ -82,6 +82,8 @@ jobs: ubuntu2204_test: needs: [ubuntu2204_build] + permissions: + contents: write if: ${{ always() && !cancelled() && needs.ubuntu2204_build.outputs.build_conclusion == 'success' }} strategy: fail-fast: false @@ -169,6 +171,8 @@ jobs: ubuntu2404_oneapi_test: needs: [ubuntu2404_oneapi_build] + permissions: + contents: write if: ${{ always() && !cancelled() && needs.ubuntu2404_oneapi_build.outputs.build_conclusion == 'success' }} uses: ./.github/workflows/sycl-linux-run-tests.yml with: @@ -230,6 +234,8 @@ jobs: cuda-run-tests: needs: [ubuntu2204_build, cuda-aws-start] + permissions: + contents: write if: ${{ always() && !cancelled() && needs.ubuntu2204_build.outputs.build_conclusion == 'success' }} uses: ./.github/workflows/sycl-linux-run-tests.yml with: @@ -254,6 +260,8 @@ jobs: build-sycl-cts-linux: needs: ubuntu2204_build + permissions: + contents: write if: ${{ always() && !cancelled() && needs.ubuntu2204_build.outputs.build_conclusion == 'success' }} uses: ./.github/workflows/sycl-linux-run-tests.yml with: @@ -270,6 +278,8 @@ jobs: run-sycl-cts-linux: needs: [ubuntu2204_build, build-sycl-cts-linux] + permissions: + contents: write if: ${{ always() && !cancelled() && needs.ubuntu2204_build.outputs.build_conclusion == 'success' }} strategy: fail-fast: false diff --git a/.github/workflows/sycl-post-commit.yml b/.github/workflows/sycl-post-commit.yml index ce0afb273860f..d66f486c07032 100644 --- a/.github/workflows/sycl-post-commit.yml +++ b/.github/workflows/sycl-post-commit.yml @@ -48,6 +48,8 @@ jobs: e2e-lin: needs: [detect_changes, build-lin] if: ${{ always() && !cancelled() && needs.build-lin.outputs.build_conclusion == 'success' }} + permissions: + contents: write strategy: fail-fast: false matrix: diff --git a/.github/workflows/sycl-weekly.yml b/.github/workflows/sycl-weekly.yml index d6f0af31dc62d..6670419c92281 100644 --- a/.github/workflows/sycl-weekly.yml +++ b/.github/workflows/sycl-weekly.yml @@ -22,6 +22,8 @@ jobs: # This job builds SYCL-CTS with -fsycl-use-spirv-backend-for-spirv-gen. build-sycl-cts: needs: ubuntu2204_build + permissions: + contents: write if: ${{ always() && !cancelled() && needs.ubuntu2204_build.outputs.build_conclusion == 'success' }} uses: ./.github/workflows/sycl-linux-run-tests.yml with: @@ -39,6 +41,8 @@ jobs: run-sycl-cts: needs: [ubuntu2204_build, build-sycl-cts] + permissions: + contents: write if: ${{ always() && !cancelled() && needs.ubuntu2204_build.outputs.build_conclusion == 'success' }} strategy: fail-fast: false From 983fa54ced8cf03b6c20eb737e578b279b8a8e64 Mon Sep 17 00:00:00 2001 From: Ian Li Date: Thu, 30 Oct 2025 22:08:48 -0700 Subject: [PATCH 20/22] this is so stupid --- .github/workflows/sycl-linux-precommit.yml | 2 ++ .github/workflows/sycl-nightly.yml | 5 +++++ .github/workflows/sycl-post-commit.yml | 1 + .github/workflows/sycl-weekly.yml | 2 ++ 4 files changed, 10 insertions(+) diff --git a/.github/workflows/sycl-linux-precommit.yml b/.github/workflows/sycl-linux-precommit.yml index 51b00a01ff379..6d8c95c73e136 100644 --- a/.github/workflows/sycl-linux-precommit.yml +++ b/.github/workflows/sycl-linux-precommit.yml @@ -146,6 +146,7 @@ jobs: if: ${{ always() && !cancelled() && needs.build.outputs.build_conclusion == 'success' }} permissions: contents: write + packages: read strategy: fail-fast: false matrix: @@ -235,6 +236,7 @@ jobs: needs: [build, detect_changes] permissions: contents: write + packages: read if: | always() && !cancelled() && needs.build.outputs.build_conclusion == 'success' diff --git a/.github/workflows/sycl-nightly.yml b/.github/workflows/sycl-nightly.yml index 4ba42e293938f..e207fcd4a506e 100644 --- a/.github/workflows/sycl-nightly.yml +++ b/.github/workflows/sycl-nightly.yml @@ -84,6 +84,7 @@ jobs: needs: [ubuntu2204_build] permissions: contents: write + packages: read if: ${{ always() && !cancelled() && needs.ubuntu2204_build.outputs.build_conclusion == 'success' }} strategy: fail-fast: false @@ -173,6 +174,7 @@ jobs: needs: [ubuntu2404_oneapi_build] permissions: contents: write + packages: read if: ${{ always() && !cancelled() && needs.ubuntu2404_oneapi_build.outputs.build_conclusion == 'success' }} uses: ./.github/workflows/sycl-linux-run-tests.yml with: @@ -236,6 +238,7 @@ jobs: needs: [ubuntu2204_build, cuda-aws-start] permissions: contents: write + packages: read if: ${{ always() && !cancelled() && needs.ubuntu2204_build.outputs.build_conclusion == 'success' }} uses: ./.github/workflows/sycl-linux-run-tests.yml with: @@ -262,6 +265,7 @@ jobs: needs: ubuntu2204_build permissions: contents: write + packages: read if: ${{ always() && !cancelled() && needs.ubuntu2204_build.outputs.build_conclusion == 'success' }} uses: ./.github/workflows/sycl-linux-run-tests.yml with: @@ -280,6 +284,7 @@ jobs: needs: [ubuntu2204_build, build-sycl-cts-linux] permissions: contents: write + packages: read if: ${{ always() && !cancelled() && needs.ubuntu2204_build.outputs.build_conclusion == 'success' }} strategy: fail-fast: false diff --git a/.github/workflows/sycl-post-commit.yml b/.github/workflows/sycl-post-commit.yml index d66f486c07032..438259efb1c86 100644 --- a/.github/workflows/sycl-post-commit.yml +++ b/.github/workflows/sycl-post-commit.yml @@ -50,6 +50,7 @@ jobs: if: ${{ always() && !cancelled() && needs.build-lin.outputs.build_conclusion == 'success' }} permissions: contents: write + packages: read strategy: fail-fast: false matrix: diff --git a/.github/workflows/sycl-weekly.yml b/.github/workflows/sycl-weekly.yml index 6670419c92281..efd42991a8461 100644 --- a/.github/workflows/sycl-weekly.yml +++ b/.github/workflows/sycl-weekly.yml @@ -24,6 +24,7 @@ jobs: needs: ubuntu2204_build permissions: contents: write + packages: read if: ${{ always() && !cancelled() && needs.ubuntu2204_build.outputs.build_conclusion == 'success' }} uses: ./.github/workflows/sycl-linux-run-tests.yml with: @@ -43,6 +44,7 @@ jobs: needs: [ubuntu2204_build, build-sycl-cts] permissions: contents: write + packages: read if: ${{ always() && !cancelled() && needs.ubuntu2204_build.outputs.build_conclusion == 'success' }} strategy: fail-fast: false From fad9baeec8ace13698a74f2dc7f9bf6e914d3afd Mon Sep 17 00:00:00 2001 From: Ian Li Date: Thu, 30 Oct 2025 22:12:51 -0700 Subject: [PATCH 21/22] fix const --- devops/actions/run-tests/benchmark/action.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/devops/actions/run-tests/benchmark/action.yml b/devops/actions/run-tests/benchmark/action.yml index 07515fd8a3484..2f3461c00ae00 100644 --- a/devops/actions/run-tests/benchmark/action.yml +++ b/devops/actions/run-tests/benchmark/action.yml @@ -37,6 +37,9 @@ inputs: type: string required: False +env: + BENCHMARK_RESULTS_BRANCH: "sycl-benchmark-ci-results" + runs: using: "composite" steps: @@ -79,9 +82,6 @@ runs: python3 ./devops/scripts/benchmarks/presets.py query "$PRESET" [ "$?" -ne 0 ] && exit 1 # Stop workflow if invalid preset echo "PRESET=$PRESET" >> $GITHUB_ENV - - # Set branch containing benchmark CI results: - echo "BENCHMARK_RESULTS_BRANCH=sycl-benchmark-ci-results" >> $GITHUB_ENV - name: Compute CPU core range to run benchmarks on shell: bash run: | From 0c4e7e217d1948ce65ff7d465402184775f1c880 Mon Sep 17 00:00:00 2001 From: Ian Li Date: Fri, 31 Oct 2025 14:13:10 -0700 Subject: [PATCH 22/22] fix perms --- .github/workflows/sycl-linux-run-tests.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/sycl-linux-run-tests.yml b/.github/workflows/sycl-linux-run-tests.yml index 2cca8802fae3f..34f451265d42b 100644 --- a/.github/workflows/sycl-linux-run-tests.yml +++ b/.github/workflows/sycl-linux-run-tests.yml @@ -235,6 +235,7 @@ jobs: runs-on: ${{ fromJSON(inputs.runner) }} permissions: contents: write + packages: read container: image: ${{ inputs.image || 'ghcr.io/intel/llvm/ubuntu2404_intel_drivers:alldeps'}} options: ${{ inputs.image_options }}