-
Notifications
You must be signed in to change notification settings - Fork 794
[SYCL][test] Throw if order of ABI symbols is incorrect #20424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Example of the script failing when ABI symbol ordering is wrong: |
|
Jenkins CI failure is because of: which is unrelated to this PR and I suppose we also have an internal ticket tracking this failure. |
|
@uditagarwal97 just a thought - if you change the ABI you have to re-generate dumps on both OS (and I hate using windows :D). Maybe we could automate this by adding a step like "generate & upload ABI dump as an artifact" to reusable build workflows aka sycl-linux-build and so on. |
I've done that inside Windows build quite some time ago. From this PR's https://github.com/intel/llvm/actions/runs/18698871155/job/53331719766?pr=20424:
And the artifact with full re-generated symbols dump is available at https://github.com/intel/llvm/actions/runs/18698871155?pr=20424 as well, although I usually just expand the diff and copy added symbols to proper places locally. |

Recently, there were several occurrences where developers manually updated the ABI symbol dump file to add a new symbol. This results into unrelated changes on PRs when someone correctly uses
abi_check.pyfile to regenerate the ABI symbols, (for example: #20422)This PR makes
abi_check.pyto fail if the order of ABI symbols is incorrect, thus discouraging developers from manually editing the symbol dump file.