Skip to content

Conversation

@uditagarwal97
Copy link
Contributor

@uditagarwal97 uditagarwal97 commented Oct 21, 2025

Recently, there were several occurrences where developers manually updated the ABI symbol dump file to add a new symbol. This results into unrelated changes on PRs when someone correctly uses abi_check.py file to regenerate the ABI symbols, (for example: #20422)
This PR makes abi_check.py to fail if the order of ABI symbols is incorrect, thus discouraging developers from manually editing the symbol dump file.

@uditagarwal97
Copy link
Contributor Author

@uditagarwal97 uditagarwal97 marked this pull request as ready for review October 21, 2025 22:04
@uditagarwal97 uditagarwal97 requested a review from a team as a code owner October 21, 2025 22:04
@uditagarwal97
Copy link
Contributor Author

Jenkins CI failure is because of:

llvm.src/sycl-jit/jit-compiler/lib/rtc/DeviceCompilation.cpp:129:66: error: ‘StrLen’ may be used uninitialized in this function [-Werror=maybe-uninitialized]

which is unrelated to this PR and I suppose we also have an internal ticket tracking this failure.

@KornevNikita
Copy link
Contributor

@uditagarwal97 just a thought - if you change the ABI you have to re-generate dumps on both OS (and I hate using windows :D). Maybe we could automate this by adding a step like "generate & upload ABI dump as an artifact" to reusable build workflows aka sycl-linux-build and so on.

@aelovikov-intel
Copy link
Contributor

aelovikov-intel commented Oct 22, 2025

@uditagarwal97 just a thought - if you change the ABI you have to re-generate dumps on both OS (and I hate using windows :D). Maybe we could automate this by adding a step like "generate & upload ABI dump as an artifact" to reusable build workflows aka sycl-linux-build and so on.

I've done that inside Windows build quite some time ago. From this PR's https://github.com/intel/llvm/actions/runs/18698871155/job/53331719766?pr=20424:

image

And the artifact with full re-generated symbols dump is available at https://github.com/intel/llvm/actions/runs/18698871155?pr=20424 as well, although I usually just expand the diff and copy added symbols to proper places locally.

@uditagarwal97 uditagarwal97 merged commit 2f7b054 into sycl Oct 22, 2025
31 of 33 checks passed
@uditagarwal97 uditagarwal97 deleted the private/udit-abi_symbols_order branch October 22, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants