[SYCL][SPIRV BE] Disable SPV_KHR_float_controls2 extension. #20519
+79
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maarquitos14
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mdtoguchi
reviewed
Oct 30, 2025
| // is growing. Let's postpone the decision on which extensions to enable until | ||
| // - the list is stable, and | ||
| // - we decide on a mapping of user requested extensions into backend's ones. | ||
| // Meanwhile we enable all the SPIR-V backend extensions. |
There was a problem hiding this comment.
Could you update the comment to reflect the change, perhaps embellish on support expectations now and moving forward.
There was a problem hiding this comment.
I can definitely add that we are enabling all except this particular one. For the rest, I'm doing it this way to unblock LLVM-SPIRV pulldown, but I'm working on preparing the actual list with extensions to be enabled, instead of all. I can update the comment on support expectations now and in the future, but I plan to remove this comment completely in my next patch, which hopefully will take no more than 1-2 weeks.
maarquitos14
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
maarquitos14
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
maarquitos14
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
maarquitos14
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
maarquitos14
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
maarquitos14
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
maarquitos14
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
jsji
pushed a commit
that referenced
this pull request
Oct 30, 2025
SPV_KHR_float_controls2 is not supported yet by our driver, so we need to explicitly disable it for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SPV_KHR_float_controls2 is not supported yet by our driver, so we need to explicitly disable it for now.